From 6ea3b542646f45a4b279228989348a8dc229f53c Mon Sep 17 00:00:00 2001 From: Akshay Jindal Date: Sun, 12 Oct 2025 23:36:13 +0530 Subject: [PATCH] iio: accel: bma400: Add detail to comments in GEN INTR configuration Append additional information to existing comments in the generic interrupt configuration code to provide more context. Signed-off-by: Akshay Jindal Signed-off-by: Jonathan Cameron --- drivers/iio/accel/bma400_core.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/iio/accel/bma400_core.c b/drivers/iio/accel/bma400_core.c index 840c4156ba604..05f72707f8306 100644 --- a/drivers/iio/accel/bma400_core.c +++ b/drivers/iio/accel/bma400_core.c @@ -1208,7 +1208,10 @@ static int bma400_generic_event_en(struct bma400_data *data, detect_criterion = bma400_genintr->detect_mode; intrmask = bma400_genintr->intrmask; - /* Enabling all axis for interrupt evaluation */ + /* + * Enabling all axis for interrupt evaluation + * Acc_filt2 is recommended as data source in datasheet (Section 4.7) + */ ret = regmap_write(data->regmap, BMA400_GENINT_CONFIG_REG(genintr, 0), BMA400_GENINT_CONFIG0_X_EN_MASK | BMA400_GENINT_CONFIG0_Y_EN_MASK | @@ -1226,7 +1229,10 @@ static int bma400_generic_event_en(struct bma400_data *data, if (ret) return ret; - /* Initial value to avoid interrupts while enabling*/ + /* + * Initial value to avoid interrupts while enabling + * Value is in units of 8mg/lsb, i.e. effective val is val * 8mg/lsb + */ ret = regmap_write(data->regmap, BMA400_GENINT_CONFIG_REG(genintr, 2), 0x0A); if (ret) return ret; -- 2.47.3