From 6efc4495cf42c61f31397374618ea55bd31a9983 Mon Sep 17 00:00:00 2001 From: "mkanat%kerio.com" <> Date: Thu, 2 Mar 2006 05:47:58 +0000 Subject: [PATCH] Bug 328436: Move BugInGroupId from globals.pl to process_bug.cgi Patch By Max Kanat-Alexander r=wicked, a=justdave --- globals.pl | 12 ------------ process_bug.cgi | 15 +++++++++++++++ 2 files changed, 15 insertions(+), 12 deletions(-) diff --git a/globals.pl b/globals.pl index b9b6e02d5a..7242415e43 100644 --- a/globals.pl +++ b/globals.pl @@ -487,18 +487,6 @@ sub get_legal_field_values { return @$result_ref; } -sub BugInGroupId { - my ($bugid, $groupid) = (@_); - PushGlobalSQLState(); - SendSQL("SELECT CASE WHEN bug_id != 0 THEN 1 ELSE 0 END - FROM bug_group_map - WHERE bug_id = $bugid - AND group_id = $groupid"); - my $bugingroup = FetchOneColumn(); - PopGlobalSQLState(); - return $bugingroup; -} - sub GroupIdToName { my ($groupid) = (@_); PushGlobalSQLState(); diff --git a/process_bug.cgi b/process_bug.cgi index 345bce5922..d37ec52316 100755 --- a/process_bug.cgi +++ b/process_bug.cgi @@ -85,6 +85,21 @@ my $vars = {}; my $requiremilestone = 0; +###################################################################### +# Subroutines +###################################################################### + +sub BugInGroupId { + my ($bug_id, $group_id) = @_; + detaint_natural($bug_id); + detaint_natural($group_id); + my ($in_group) = Bugzilla->dbh->selectrow_array( + "SELECT CASE WHEN bug_id != 0 THEN 1 ELSE 0 END + FROM bug_group_map + WHERE bug_id = ? AND group_id = ?", undef, ($bug_id, $group_id)); + return $in_group; +} + ###################################################################### # Begin Data/Security Validation ###################################################################### -- 2.47.2