From 6f4fba5980af8a0670aa402eb046fc58a06cb1b8 Mon Sep 17 00:00:00 2001 From: "lpsolit%gmail.com" <> Date: Wed, 20 Apr 2005 01:11:41 +0000 Subject: [PATCH] =?utf8?q?Bug=20288603:=20Allow=20users=20in=20the=20reque?= =?utf8?q?st=20group=20to=20remove=20pending=20requests=20made=20by=20othe?= =?utf8?q?rs=20-=20Patch=20by=20Fr=C3=A9d=C3=A9ric=20Buclin=20=20r=3Dmyk=20a=3Djustdave?= MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit --- Bugzilla/Flag.pm | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Bugzilla/Flag.pm b/Bugzilla/Flag.pm index 29215876ab..de9c3d23b8 100644 --- a/Bugzilla/Flag.pm +++ b/Bugzilla/Flag.pm @@ -320,8 +320,11 @@ sub validate { # - The flag is unchanged next if ($status eq $flag->{status}); - # - User can clear flags set by itself - next if (($status eq "X") && ($user->id eq $flag->{setter}->id)); + # - User in the $request_gid group can clear pending requests + next if ($status eq 'X' + && $flag->{status} eq '?' + && (!$flag->{type}->{request_gid} + || $user->in_group(&::GroupIdToName($flag->{type}->{request_gid})))); # - User in the $grant_gid group can set/clear flags, # including "+" and "-" -- 2.47.2