From 70f8299285fac1533153832f47711fa1f0dbd3b6 Mon Sep 17 00:00:00 2001 From: Michal Privoznik Date: Wed, 9 Feb 2022 13:45:28 +0100 Subject: [PATCH] ch: Report VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER as supported Even though the CH driver doesn't implement virNetworkUpdate() API, when it does it will see the arguments in correct order. This is similar to other drivers that don't implement the API, like ESX, libxl, LXC, etc. Enabling this driver feature stops clients from swapping the arguments (see comment in the API for more info). Signed-off-by: Michal Privoznik Reviewed-by: Andrea Bolognani --- src/ch/ch_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ch/ch_driver.c b/src/ch/ch_driver.c index ef74a00bf7..a0ff687d05 100644 --- a/src/ch/ch_driver.c +++ b/src/ch/ch_driver.c @@ -924,6 +924,7 @@ chConnectSupportsFeature(virConnectPtr conn, switch ((virDrvFeature) feature) { case VIR_DRV_FEATURE_TYPED_PARAM_STRING: + case VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER: return 1; case VIR_DRV_FEATURE_MIGRATION_V2: case VIR_DRV_FEATURE_MIGRATION_V3: @@ -939,7 +940,6 @@ chConnectSupportsFeature(virConnectPtr conn, case VIR_DRV_FEATURE_REMOTE: case VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK: case VIR_DRV_FEATURE_REMOTE_EVENT_CALLBACK: - case VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER: default: return 0; } -- 2.47.2