From 712309eaae043f3a062a7c1dcf94f7c8059fcbcf Mon Sep 17 00:00:00 2001 From: Glenn Washburn Date: Wed, 28 Jun 2023 02:47:09 -0500 Subject: [PATCH] term/serial: Use grub_strncpy() instead of grub_snprintf() when only copying string Using grub_strncpy() instead of grub_snprintf() is less overhead and indicates clearly that the dest should be the same string as the source. Also fix indentation. Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper --- grub-core/term/serial.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/grub-core/term/serial.c b/grub-core/term/serial.c index 69fc0600f..869555430 100644 --- a/grub-core/term/serial.c +++ b/grub-core/term/serial.c @@ -257,10 +257,10 @@ grub_cmd_serial (grub_extcmd_context_t ctxt, int argc, char **args) { if (grub_strncmp (state[OPTION_PORT].arg, "mmio,", sizeof ("mmio,") - 1) == 0 || grub_strncmp (state[OPTION_PORT].arg, "pci,", sizeof ("pci,") - 1) == 0) - grub_snprintf (pname, sizeof (pname), "%s", state[1].arg); + grub_strncpy (pname, state[1].arg, sizeof (pname)); else - grub_snprintf (pname, sizeof (pname), "port%lx", - grub_strtoul (state[1].arg, 0, 0)); + grub_snprintf (pname, sizeof (pname), "port%lx", + grub_strtoul (state[1].arg, 0, 0)); name = pname; } -- 2.47.2