From 721aca1abd3a8c27995874bfccd10e59842969ce Mon Sep 17 00:00:00 2001 From: Rico Tzschichholz Date: Thu, 27 Aug 2020 10:02:19 +0200 Subject: [PATCH] libvaladoc/gtkdoc-importer: Correctly retrieve "url" from "ulink" elements This caused criticals like: g_uri_parse_scheme: assertion 'uri != NULL' failed --- libvaladoc/documentation/gtkdoccommentparser.vala | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libvaladoc/documentation/gtkdoccommentparser.vala b/libvaladoc/documentation/gtkdoccommentparser.vala index 20535b764..c1b1d0ea8 100644 --- a/libvaladoc/documentation/gtkdoccommentparser.vala +++ b/libvaladoc/documentation/gtkdoccommentparser.vala @@ -358,7 +358,12 @@ public class Valadoc.Gtkdoc.Parser : Object, ResourceLocator { } StringBuilder builder = new StringBuilder (); - string url = current.attributes.get ("linkend"); + string url; + if (is_internal) { + url = current.attributes.get ("linkend"); + } else { + url = current.attributes.get ("url"); + } next (); // TODO: check xml -- 2.47.2