From 72b9d5c809a7e00e9f056913b8b385ab928f2717 Mon Sep 17 00:00:00 2001 From: Miod Vallat Date: Fri, 25 Apr 2025 10:28:23 +0200 Subject: [PATCH] Use string_view to avoid new string creation... ...in apiCheckQNameAllowedCharacters(). --- pdns/ws-api.cc | 6 +++--- pdns/ws-api.hh | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/pdns/ws-api.cc b/pdns/ws-api.cc index 16a9f21e0a..9040853d86 100644 --- a/pdns/ws-api.cc +++ b/pdns/ws-api.cc @@ -357,14 +357,14 @@ string apiZoneNameToId(const ZoneName& dname) return identifier; } -void apiCheckNameAllowedCharacters(const string& name) +void apiCheckNameAllowedCharacters(std::string_view name) { if (name.find_first_not_of("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ01234567890_/.-") != std::string::npos) { - throw ApiException("Name '" + name + "' contains unsupported characters"); + throw ApiException("Name '" + std::string(name) + "' contains unsupported characters"); } } -void apiCheckQNameAllowedCharacters(const string& qname) +void apiCheckQNameAllowedCharacters(std::string_view qname) { if (qname.compare(0, 2, "*.") == 0) { apiCheckNameAllowedCharacters(qname.substr(2)); diff --git a/pdns/ws-api.hh b/pdns/ws-api.hh index f07bead1ab..76f1ef4077 100644 --- a/pdns/ws-api.hh +++ b/pdns/ws-api.hh @@ -34,8 +34,8 @@ void apiServerStatistics(HttpRequest* req, HttpResponse* resp); // helpers ZoneName apiZoneIdToName(const string& identifier); string apiZoneNameToId(const ZoneName& name); -void apiCheckNameAllowedCharacters(const string& name); -void apiCheckQNameAllowedCharacters(const string& name); +void apiCheckNameAllowedCharacters(std::string_view name); +void apiCheckQNameAllowedCharacters(std::string_view name); DNSName apiNameToDNSName(const string& name); #if defined(PDNS_AUTH) ZoneName apiNameToZoneName(const string& name); -- 2.47.2