From 737e40d5eb2f6507113285cb52c50a4a6b01f44a Mon Sep 17 00:00:00 2001 From: SeongJae Park Date: Sun, 6 Jul 2025 12:32:05 -0700 Subject: [PATCH] mm/damon/reclaim: reset enabled when DAMON start failed When the startup fails, 'enabled' parameter is not reset. As a result, users show the parameter 'Y' while it is not really working. Fix it by resetting 'enabled' to 'false' when the work is failed. Link: https://lkml.kernel.org/r/20250706193207.39810-5-sj@kernel.org Fixes: 04e98764befa ("mm/damon/reclaim: enable and disable synchronously") Signed-off-by: SeongJae Park Signed-off-by: Andrew Morton --- mm/damon/reclaim.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c index a675150965e02..c91098d8aa51a 100644 --- a/mm/damon/reclaim.c +++ b/mm/damon/reclaim.c @@ -329,7 +329,7 @@ static int __init damon_reclaim_init(void) int err = damon_modules_new_paddr_ctx_target(&ctx, &target); if (err) - return err; + goto out; ctx->callback.after_wmarks_check = damon_reclaim_after_wmarks_check; ctx->callback.after_aggregation = damon_reclaim_after_aggregation; @@ -338,6 +338,9 @@ static int __init damon_reclaim_init(void) if (enabled) err = damon_reclaim_turn(true); +out: + if (err && enabled) + enabled = false; return err; } -- 2.47.2