From 73c6d27e33e384d407bcb6e81a49dacd492598cf Mon Sep 17 00:00:00 2001 From: Tim Ringenbach Date: Tue, 4 May 2010 17:40:59 +0000 Subject: [PATCH] Fix FILTER() examples to work in 1.4 Review: https://reviewboard.asterisk.org/r/644/ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@260887 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- README-SERIOUSLY.bestpractices.txt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/README-SERIOUSLY.bestpractices.txt b/README-SERIOUSLY.bestpractices.txt index 0e2af3b4a4..60381c242c 100644 --- a/README-SERIOUSLY.bestpractices.txt +++ b/README-SERIOUSLY.bestpractices.txt @@ -121,7 +121,7 @@ we will accept to just numbers. Our example would then change to something like: [incoming] exten => _X.,1,Verbose(2,Incoming call to extension ${EXTEN}) -exten => _X.,n,Dial(SIP/${FILTER(0-9,${EXTEN})}) +exten => _X.,n,Dial(SIP/${FILTER(0123456789,${EXTEN})}) exten => _X.,n,Hangup() Note how we've wrapped the ${EXTEN} channel variable with the FILTER() function @@ -135,7 +135,7 @@ necessary, and to handle error checking in a separate location. [incoming] exten => _X.,1,Verbose(2,Incoming call to extension ${EXTEN}) -exten => _X.,n,Set(SAFE_EXTEN=${FILTER(0-9,${EXTEN})}) +exten => _X.,n,Set(SAFE_EXTEN=${FILTER(0123456789,${EXTEN})}) exten => _X.,n,Dial(SIP/${SAFE_EXTEN}) exten => _X.,n,Hangup() @@ -146,7 +146,7 @@ passed back by FILTER(), and to fail the call if things do not match. [incoming] exten => _X.,1,Verbose(2,Incoming call to extension ${EXTEN}) -exten => _X.,n,Set(SAFE_EXTEN=${FILTER(0-9,${EXTEN})}) +exten => _X.,n,Set(SAFE_EXTEN=${FILTER(0123456789,${EXTEN})}) exten => _X.,n,GotoIf($[${EXTEN} != ${SAFE_EXTEN}]?error,1) exten => _X.,n,Dial(SIP/${SAFE_EXTEN}) exten => _X.,n,Hangup() @@ -161,7 +161,7 @@ we're expecting to get a SIP URI for dialing. [incoming] exten => _[0-9a-zA-Z].,1,Verbose(2,Incoming call to extension ${EXTEN}) -exten => _[0-9a-zA-Z].,n,Dial(SIP/${FILTER(.@0-9a-zA-Z,${EXTEN}) +exten => _[0-9a-zA-Z].,n,Dial(SIP/${FILTER(.@0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ,${EXTEN}) exten => _[0-9a-zA-Z].,n,Hangup() Of course the FILTER() function doesn't check the formatting of the incoming -- 2.47.2