From 74ddd53a7297f4dabf83c837a8fca65254f45a8c Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Wed, 14 Feb 2024 14:09:03 +0100 Subject: [PATCH] 5.4-stable patches added patches: net-stmmac-xgmac-use-define-for-string-constants.patch --- ...gmac-use-define-for-string-constants.patch | 124 ++++++++++++++++++ queue-5.4/series | 1 + 2 files changed, 125 insertions(+) create mode 100644 queue-5.4/net-stmmac-xgmac-use-define-for-string-constants.patch diff --git a/queue-5.4/net-stmmac-xgmac-use-define-for-string-constants.patch b/queue-5.4/net-stmmac-xgmac-use-define-for-string-constants.patch new file mode 100644 index 00000000000..ee5c482eea5 --- /dev/null +++ b/queue-5.4/net-stmmac-xgmac-use-define-for-string-constants.patch @@ -0,0 +1,124 @@ +From 1692b9775e745f84b69dc8ad0075b0855a43db4e Mon Sep 17 00:00:00 2001 +From: Simon Horman +Date: Thu, 8 Feb 2024 09:48:27 +0000 +Subject: net: stmmac: xgmac: use #define for string constants + +From: Simon Horman + +commit 1692b9775e745f84b69dc8ad0075b0855a43db4e upstream. + +The cited commit introduces and uses the string constants dpp_tx_err and +dpp_rx_err. These are assigned to constant fields of the array +dwxgmac3_error_desc. + +It has been reported that on GCC 6 and 7.5.0 this results in warnings +such as: + + .../dwxgmac2_core.c:836:20: error: initialiser element is not constant + { true, "TDPES0", dpp_tx_err }, + +I have been able to reproduce this using: GCC 7.5.0, 8.4.0, 9.4.0 and 10.5.0. +But not GCC 13.2.0. + +So it seems this effects older compilers but not newer ones. +As Jon points out in his report, the minimum compiler supported by +the kernel is GCC 5.1, so it does seem that this ought to be fixed. + +It is not clear to me what combination of 'const', if any, would address +this problem. So this patch takes of using #defines for the string +constants + +Compile tested only. + +Fixes: 46eba193d04f ("net: stmmac: xgmac: fix handling of DPP safety error for DMA channels") +Reported-by: Jon Hunter +Closes: https://lore.kernel.org/netdev/c25eb595-8d91-40ea-9f52-efa15ebafdbc@nvidia.com/ +Reported-by: kernel test robot +Closes: https://lore.kernel.org/oe-kbuild-all/202402081135.lAxxBXHk-lkp@intel.com/ +Signed-off-by: Simon Horman +Link: https://lore.kernel.org/r/20240208-xgmac-const-v1-1-e69a1eeabfc8@kernel.org +Signed-off-by: Jakub Kicinski +Signed-off-by: Greg Kroah-Hartman +--- + drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c | 69 ++++++++++---------- + 1 file changed, 35 insertions(+), 34 deletions(-) + +--- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c ++++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c +@@ -757,41 +757,42 @@ static const struct dwxgmac3_error_desc + { false, "UNKNOWN", "Unknown Error" }, /* 31 */ + }; + +-static const char * const dpp_rx_err = "Read Rx Descriptor Parity checker Error"; +-static const char * const dpp_tx_err = "Read Tx Descriptor Parity checker Error"; ++#define DPP_RX_ERR "Read Rx Descriptor Parity checker Error" ++#define DPP_TX_ERR "Read Tx Descriptor Parity checker Error" ++ + static const struct dwxgmac3_error_desc dwxgmac3_dma_dpp_errors[32] = { +- { true, "TDPES0", dpp_tx_err }, +- { true, "TDPES1", dpp_tx_err }, +- { true, "TDPES2", dpp_tx_err }, +- { true, "TDPES3", dpp_tx_err }, +- { true, "TDPES4", dpp_tx_err }, +- { true, "TDPES5", dpp_tx_err }, +- { true, "TDPES6", dpp_tx_err }, +- { true, "TDPES7", dpp_tx_err }, +- { true, "TDPES8", dpp_tx_err }, +- { true, "TDPES9", dpp_tx_err }, +- { true, "TDPES10", dpp_tx_err }, +- { true, "TDPES11", dpp_tx_err }, +- { true, "TDPES12", dpp_tx_err }, +- { true, "TDPES13", dpp_tx_err }, +- { true, "TDPES14", dpp_tx_err }, +- { true, "TDPES15", dpp_tx_err }, +- { true, "RDPES0", dpp_rx_err }, +- { true, "RDPES1", dpp_rx_err }, +- { true, "RDPES2", dpp_rx_err }, +- { true, "RDPES3", dpp_rx_err }, +- { true, "RDPES4", dpp_rx_err }, +- { true, "RDPES5", dpp_rx_err }, +- { true, "RDPES6", dpp_rx_err }, +- { true, "RDPES7", dpp_rx_err }, +- { true, "RDPES8", dpp_rx_err }, +- { true, "RDPES9", dpp_rx_err }, +- { true, "RDPES10", dpp_rx_err }, +- { true, "RDPES11", dpp_rx_err }, +- { true, "RDPES12", dpp_rx_err }, +- { true, "RDPES13", dpp_rx_err }, +- { true, "RDPES14", dpp_rx_err }, +- { true, "RDPES15", dpp_rx_err }, ++ { true, "TDPES0", DPP_TX_ERR }, ++ { true, "TDPES1", DPP_TX_ERR }, ++ { true, "TDPES2", DPP_TX_ERR }, ++ { true, "TDPES3", DPP_TX_ERR }, ++ { true, "TDPES4", DPP_TX_ERR }, ++ { true, "TDPES5", DPP_TX_ERR }, ++ { true, "TDPES6", DPP_TX_ERR }, ++ { true, "TDPES7", DPP_TX_ERR }, ++ { true, "TDPES8", DPP_TX_ERR }, ++ { true, "TDPES9", DPP_TX_ERR }, ++ { true, "TDPES10", DPP_TX_ERR }, ++ { true, "TDPES11", DPP_TX_ERR }, ++ { true, "TDPES12", DPP_TX_ERR }, ++ { true, "TDPES13", DPP_TX_ERR }, ++ { true, "TDPES14", DPP_TX_ERR }, ++ { true, "TDPES15", DPP_TX_ERR }, ++ { true, "RDPES0", DPP_RX_ERR }, ++ { true, "RDPES1", DPP_RX_ERR }, ++ { true, "RDPES2", DPP_RX_ERR }, ++ { true, "RDPES3", DPP_RX_ERR }, ++ { true, "RDPES4", DPP_RX_ERR }, ++ { true, "RDPES5", DPP_RX_ERR }, ++ { true, "RDPES6", DPP_RX_ERR }, ++ { true, "RDPES7", DPP_RX_ERR }, ++ { true, "RDPES8", DPP_RX_ERR }, ++ { true, "RDPES9", DPP_RX_ERR }, ++ { true, "RDPES10", DPP_RX_ERR }, ++ { true, "RDPES11", DPP_RX_ERR }, ++ { true, "RDPES12", DPP_RX_ERR }, ++ { true, "RDPES13", DPP_RX_ERR }, ++ { true, "RDPES14", DPP_RX_ERR }, ++ { true, "RDPES15", DPP_RX_ERR }, + }; + + static void dwxgmac3_handle_dma_err(struct net_device *ndev, diff --git a/queue-5.4/series b/queue-5.4/series index a2c9e537f15..27d2404d5bf 100644 --- a/queue-5.4/series +++ b/queue-5.4/series @@ -198,3 +198,4 @@ usb-serial-cp210x-add-id-for-imst-im871a-usb.patch hrtimer-report-offline-hrtimer-enqueue.patch input-atkbd-skip-atkbd_cmd_setleds-when-skipping-atkbd_cmd_getid.patch vhost-use-kzalloc-instead-of-kmalloc-followed-by-memset.patch +net-stmmac-xgmac-use-define-for-string-constants.patch -- 2.47.3