From 7515e01e6e1370c23fc3a781ec2f54140583d86b Mon Sep 17 00:00:00 2001 From: JiashengJiang Date: Fri, 16 May 2025 20:20:47 -0400 Subject: [PATCH] test/evp_test.c: Free fetched_digest on error to avoid memory leak Call EVP_MD_free() to release fetched_digest if OPENSSL_zalloc() fails, preventing a memory leak. Fixes: 2208ba56eb ("evp_test: Add the missing check after calling OPENSSL_malloc") Signed-off-by: JiashengJiang Reviewed-by: Matt Caswell Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/27648) (cherry picked from commit e8deb32af4874c781838c1596c6355712b5d0ed0) --- test/evp_test.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/evp_test.c b/test/evp_test.c index d8923871404..7ba123da952 100644 --- a/test/evp_test.c +++ b/test/evp_test.c @@ -374,8 +374,10 @@ static int digest_test_init(EVP_TEST *t, const char *alg) if ((digest = fetched_digest = EVP_MD_fetch(libctx, alg, propquery)) == NULL && (digest = EVP_get_digestbyname(alg)) == NULL) return 0; - if (!TEST_ptr(mdat = OPENSSL_zalloc(sizeof(*mdat)))) + if (!TEST_ptr(mdat = OPENSSL_zalloc(sizeof(*mdat)))) { + EVP_MD_free(fetched_digest); return 0; + } t->data = mdat; mdat->digest = digest; mdat->fetched_digest = fetched_digest; -- 2.47.2