From 75c4b6fda7592cad4c3266906408cd30a0f9cc16 Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Fri, 2 Aug 2019 14:04:58 -0400 Subject: [PATCH] Use new create_mock_engine strategy="mock" is deprecated in 1.4 Change-Id: Ie96b7575c6ef9ca9e22874fb1bf1c19518bde3da --- alembic/testing/fixtures.py | 4 ++-- alembic/util/sqla_compat.py | 12 ++++++++++++ 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/alembic/testing/fixtures.py b/alembic/testing/fixtures.py index f45d7177..86cdfef8 100644 --- a/alembic/testing/fixtures.py +++ b/alembic/testing/fixtures.py @@ -4,7 +4,6 @@ import io import re from sqlalchemy import Column -from sqlalchemy import create_engine from sqlalchemy import inspect from sqlalchemy import MetaData from sqlalchemy import String @@ -23,6 +22,7 @@ from ..operations import Operations from ..util.compat import configparser from ..util.compat import string_types from ..util.compat import text_type +from ..util.sqla_compat import create_mock_engine testing_config = configparser.ConfigParser() testing_config.read(["test.cfg"]) @@ -34,7 +34,7 @@ def capture_db(): def dump(sql, *multiparams, **params): buf.append(str(sql.compile(dialect=engine.dialect))) - engine = create_engine("postgresql://", strategy="mock", executor=dump) + engine = create_mock_engine("postgresql://", dump) return engine, buf diff --git a/alembic/util/sqla_compat.py b/alembic/util/sqla_compat.py index 5fa43324..46becc05 100644 --- a/alembic/util/sqla_compat.py +++ b/alembic/util/sqla_compat.py @@ -29,6 +29,7 @@ sqla_110 = _vers >= (1, 1, 0) sqla_1115 = _vers >= (1, 1, 15) sqla_120 = _vers >= (1, 2, 0) sqla_1216 = _vers >= (1, 2, 16) +sqla_14 = _vers >= (1, 4) AUTOINCREMENT_DEFAULT = "auto" @@ -220,3 +221,14 @@ def _mariadb_normalized_version_info(mysql_dialect): return mysql_dialect.server_version_info[3:] else: return mysql_dialect.server_version_info + + +if sqla_14: + from sqlalchemy import create_mock_engine +else: + from sqlalchemy import create_engine + + def create_mock_engine(url, executor): + return create_engine( + "postgresql://", strategy="mock", executor=executor + ) -- 2.47.2