From 75d073fca1d019d95aa600c6ac7b50be9669b38a Mon Sep 17 00:00:00 2001 From: Travis Cross Date: Sat, 24 May 2014 00:34:12 +0000 Subject: [PATCH] Avoid useless NAT log message If FS is not behind NAT, then every call generates at least three INFO-level log messages: [INFO] switch_nat.c:589 NAT port mapping disabled This is useless noise. The message is only interesting if you do have NAT enabled but mapping disabled, which might indicate a configuration issue. With this change, we just skip the entire nat_add_mapping function if the NAT system isn't initialized or we're not behind NAT. --- src/switch_nat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/switch_nat.c b/src/switch_nat.c index ff1b68d628..332ad43c7f 100644 --- a/src/switch_nat.c +++ b/src/switch_nat.c @@ -586,6 +586,7 @@ SWITCH_DECLARE(switch_status_t) switch_nat_add_mapping_internal(switch_port_t po switch_status_t status = SWITCH_STATUS_FALSE; switch_event_t *event = NULL; + if (!initialized || !nat_globals.nat_type) return status; if (!nat_globals.mapping) { switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_INFO, "NAT port mapping disabled\n"); return status; -- 2.47.2