From 76ad9ae6fa459af0bd804c01d3d681ec02cddb4b Mon Sep 17 00:00:00 2001 From: Pauli Date: Fri, 29 Jul 2022 12:08:04 +1000 Subject: [PATCH] Coverity 1507484: dereference before null check Reviewed-by: Hugo Landau Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/18907) --- ssl/tls_srp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ssl/tls_srp.c b/ssl/tls_srp.c index 2f1d2198fd1..962e4d70740 100644 --- a/ssl/tls_srp.c +++ b/ssl/tls_srp.c @@ -90,9 +90,9 @@ int SSL_SRP_CTX_free(SSL *s) */ int ssl_srp_ctx_init_intern(SSL_CONNECTION *s) { - SSL_CTX *ctx = SSL_CONNECTION_GET_CTX(s); + SSL_CTX *ctx; - if (s == NULL || ctx == NULL) + if (s == NULL || (ctx = SSL_CONNECTION_GET_CTX(s)) == NULL) return 0; memset(&s->srp_ctx, 0, sizeof(s->srp_ctx)); -- 2.47.2