From 778ea7db809b441b3efede0b135bae8fa128bcc7 Mon Sep 17 00:00:00 2001
From: Marc Schumann <wurblzap@gmail.com>
Date: Sat, 14 Apr 2012 18:06:14 +0200
Subject: [PATCH] Change columns: empty buttons when images turned off.
 r/a=LpSolit

https://bugzilla.mozilla.org/show_bug.cgi?id=474747
---
 skins/standard/global.css                     |  33 ++++--------------
 skins/standard/global/down.png                | Bin 335 -> 0 bytes
 skins/standard/global/left.png                | Bin 339 -> 0 bytes
 skins/standard/global/right.png               | Bin 339 -> 0 bytes
 skins/standard/global/up.png                  | Bin 318 -> 0 bytes
 .../en/default/list/change-columns.html.tmpl  |  23 ++++++------
 6 files changed, 19 insertions(+), 37 deletions(-)
 delete mode 100644 skins/standard/global/down.png
 delete mode 100644 skins/standard/global/left.png
 delete mode 100644 skins/standard/global/right.png
 delete mode 100644 skins/standard/global/up.png

diff --git a/skins/standard/global.css b/skins/standard/global.css
index 066fa6b77c..905a971589 100644
--- a/skins/standard/global.css
+++ b/skins/standard/global.css
@@ -392,6 +392,12 @@ dl dl > dt {
     white-space: normal !important;
 }
 
+/* Arrow buttons are buttons with only &uarr;, &darr;, &larr; or &rarr; on
+ * them. We want these to look a little less spidery. */
+.arrow_button {
+    font-size: 150%;
+}
+
 /* Style of the attachment table and time tracking table */
 #attachment_table {
     border-collapse: collapse;
@@ -543,30 +549,3 @@ input.required, select.required, span.required_explanation {
     border: 2px solid #B70000;
     background-color: #FFEBEB;
 }
-
-/*****************/
-/* colchange.cgi */
-/*****************/
-
-.image_button {
-    background-repeat: no-repeat;
-    background-position: center center;
-    width: 30px;
-    height: 20px;
-}
-
-#select_button {
-    background-image: url(global/right.png);
-}
-
-#deselect_button {
-    background-image: url(global/left.png);
-}
-
-#up_button {
-    background-image: url(global/up.png);
-}
-
-#down_button {
-    background-image: url(global/down.png);
-}
diff --git a/skins/standard/global/down.png b/skins/standard/global/down.png
deleted file mode 100644
index 78a9e631a4ed2567c045701523e9063106957276..0000000000000000000000000000000000000000
GIT binary patch
literal 0
Hc-jL100001

literal 335
zc-rd>@N?(olHy`uVBq!ia0vp^0wB!61|;P_|4#%`EX7WqAsj$Z!;#Vf<Z~8yL>2?p
zUk71ECym(^Ktah8*NBqf{Irtt#G+J&^73-M%)IR4<ivthz5Jr|+3#$mfQrs|x;Tbd
z^e&xj%XP>>pmo2XV|PNT@YW4oD>&p7T9>MC*dVmWL+^pCO@P+hqnGTa_MTVLnsxWb
z^wz|g5BK&bwi$YcRF>vnUBkbI>#FXhix<6$n1vd-CjQv6)$4Dw_=O+r0nD?u@AsD2
zR>vCCV7P(7&n57Ew8OsEr<;6dt()oRF2h$`w!6>W`mj#rDRYlVyR!-sT<7MUoPIRY
zAYh(tm^k+){WCKa_Wkbq{hy`MaCgIZf#Yx3e<;QkTRspC%9_@)cdy%KPKHbSLV~`|
aS^vIC?M~nMOh=%<7(8A5T-G@yGywnusetAH

diff --git a/skins/standard/global/left.png b/skins/standard/global/left.png
deleted file mode 100644
index f8cb2b2dddf9a902bd200f28e69624278c7be8af..0000000000000000000000000000000000000000
GIT binary patch
literal 0
Hc-jL100001

literal 339
zc-rd>@N?(olHy`uVBq!ia0vp^0wB!61|;P_|4#%`EX7WqAsj$Z!;#Vf<Z~8yL>2?p
zUk71ECym(^Ktah8*NBqf{Irtt#G+J&^73-M%)IR4<ivthz5Jr|+3#$mfQl}7x;Tbd
z^e&xj%XP>>pmjf|P{0<S+1Hpk!pzF5`1Ur6f6%z6w6;n7f^fvmrAA6DCpSm@?=|e?
z<`*lwfBf8;=*dUyPixzlzD~NflHEX>Avz&U_Q4s!2jcq-#06Lmuip9hG*7~HwW<dH
z%{SG3l{c;VT9VGHQ@n?JiR`2~%Px0H^-gwBHJyH&vo+CwUiq4YeatcZkAC<}yUNwV
zta6e~g3&XyVXw+Z!+p;=r{p~HH4u=wm;HCyc^QxFgqUq}{;1d~ywq<H{pYq>Z-cwl
d73L`s;?<=~`vt`>PY3#q!PC{xWt~$(698zDd&&R+

diff --git a/skins/standard/global/right.png b/skins/standard/global/right.png
deleted file mode 100644
index d02b707a64e042bc61979a5f7a5a2a197cdf67e4..0000000000000000000000000000000000000000
GIT binary patch
literal 0
Hc-jL100001

literal 339
zc-rd>@N?(olHy`uVBq!ia0vp^0wB!61|;P_|4#%`EX7WqAsj$Z!;#Vf<Z~8yL>2?p
zUk71ECym(^Ktah8*NBqf{Irtt#G+J&^73-M%)IR4<ivthz5Jr|+3#$mfQl}7x;Tbd
z^e&yem-mnZPpiE%ho*y9?~05Sn;3<*tU1V~b3h~KAk$0+t!E8t`}>)gR2~H|O<Obh
z-Oc$m{^^sC*kAm;YF4k|?EicXx&=paK58=@VCU02p?=^)AzMY<(*76${sx0N6IG-y
zZAq}=J-Mk#L1M!5i_y8Pk;+HUM|*OVF>O85ouJ6+*{}YiZhx!zS<gk&*(>A97_L0x
z(>SfS|0UO&iGBeyIjY@1az)f-<jr_-YS&KF&#%<B$y?`f<ua^XEqP#H-r}1QGZf~|
eRsFy2GjFzN<I8>1SuB8lWAJqKb6Mw<&;$VfQGO%<

diff --git a/skins/standard/global/up.png b/skins/standard/global/up.png
deleted file mode 100644
index 240d483df772f30a2222624f73f41f4beb8813e4..0000000000000000000000000000000000000000
GIT binary patch
literal 0
Hc-jL100001

literal 318
zc-rd>@N?(olHy`uVBq!ia0vp^0wB!61|;P_|4#%`EX7WqAsj$Z!;#Vf<Z~8yL>2?p
zUk71ECym(^Ktah8*NBqf{Irtt#G+J&^73-M%)IR4<ivthz5Jr|+3#$mfQoi|x;Tbd
z^j@93k@t{+h|7EF=)zw<6WUJ6rm`f78F^GqOAv`@ZBo*8;?U@0a#u*6?XmL5CC_i$
z@9*4^uh^-%bklMrJ|(^C_LLY0=Lc`DE_wI2>E%?DpKYtNWDi76PF&~_6}5Xw&~%PD
zCY8IlzHN(&H!isHg!TH?#V2Z6Y+kq}_zB%=FLa5_3lxz$cILu&Zidwg8<-pZ9{(rO
z9q1v&6#L|=-ZUo*50(!n`1}HXdj8>Np8Mjx+c$;a{hx)+lO=a=?~%C*^ag{ctDnm{
Hr-UW|eQkIV

diff --git a/template/en/default/list/change-columns.html.tmpl b/template/en/default/list/change-columns.html.tmpl
index b823d497d1..17d711eec8 100644
--- a/template/en/default/list/change-columns.html.tmpl
+++ b/template/en/default/list/change-columns.html.tmpl
@@ -41,8 +41,7 @@
       <tr>
         <th><div id="avail_header" class="bz_default_hidden">Available Columns</div></th>
         <th></th>
-        <th>Selected Columns</th>
-        <th></th>
+        <th colspan="2">Selected Columns</th>
       </tr>
       <tr>
         <td>
@@ -52,11 +51,13 @@
           </select>
         </td>
         <td>
-          <input class="image_button bz_default_hidden" type="button" 
-                 id="select_button" name="select" onclick="move_select()">
+          <button type="button" id="select_button" name="select"
+                  class="bz_default_hidden arrow_button"
+                  onclick="move_select()">&rarr;</button>
           <br><br>
-          <input class="image_button bz_default_hidden" type="button" 
-                 id="deselect_button" name="deselect" onclick="move_deselect()">
+          <button type="button" id="deselect_button" name="deselect"
+                  class="bz_default_hidden arrow_button"
+                  onclick="move_deselect()">&larr;</button>
         </td>
         <td>
           <select name="selected_columns" id="selected_columns" 
@@ -77,11 +78,13 @@
           </select>
         </td>
         <td>
-          <input class="image_button bz_default_hidden" type="button" 
-                 id="up_button" name="up" onclick="move_up()">
+          <button type="button" id="up_button" name="up"
+                  class="bz_default_hidden arrow_button"
+                  onclick="move_up()">&uarr;</button>
           <br><br>
-          <input class="image_button bz_default_hidden" type="button"
-                 id="down_button" name="down" onclick="move_down()">
+          <button type="button" id="down_button" name="down"
+                  class="bz_default_hidden arrow_button"
+                  onclick="move_down()">&darr;</button>
         </td>
       </tr>
     </table>
-- 
2.47.2