From 784c38f50e70a739400cdd3f2620bac2e2788e6c Mon Sep 17 00:00:00 2001 From: Greg Hudson Date: Thu, 1 Aug 2024 02:41:15 -0400 Subject: [PATCH] Update k5_sendto() comment Edit the block comment above k5_sendto() to take into account commits 802318cda963456b3ed7856c836e89da891483be (which added request_timeout) and 6436a3808061da787a43c6810f5f0370cdfb6e36 (which made the open TCP connection wait indefinite). --- src/lib/krb5/os/sendto_kdc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/lib/krb5/os/sendto_kdc.c b/src/lib/krb5/os/sendto_kdc.c index 0ffc04bd5a..4b2906139d 100644 --- a/src/lib/krb5/os/sendto_kdc.c +++ b/src/lib/krb5/os/sendto_kdc.c @@ -1470,7 +1470,7 @@ service_fds(krb5_context context, struct select_state *selstate, } /* - * Current worst-case timeout behavior: + * Current timeout behavior when no request_timeout is set: * * First pass, 1s per udp or tcp server, plus 2s at end. * Second pass, 1s per udp server, plus 4s. @@ -1489,9 +1489,9 @@ service_fds(krb5_context context, struct select_state *selstate, * * Note that if you try to reach two ports on one server, it counts as two. * - * There is one exception to the above rules. Whenever a TCP connection is - * established, we wait up to ten seconds for it to finish or fail before - * moving on. This reduces network traffic significantly in a TCP environment. + * If a TCP connection is established, we wait on it indefinitely (or until + * request_timeout has elapsed) and do not attempt to contact additional + * servers. */ krb5_error_code -- 2.47.2