From 78779efb1543adc82732767e2ca88811766c3c82 Mon Sep 17 00:00:00 2001 From: Shamil Date: Thu, 17 Apr 2025 19:26:42 +0300 Subject: [PATCH] refactor: clean up unused variables in engine module Removed unused variables to improve code clarity and maintainability. This change simplifies logic in `base.py`, `default.py`, and `result.py`. No functionality was altered. --- lib/sqlalchemy/engine/base.py | 2 +- lib/sqlalchemy/engine/default.py | 4 +--- lib/sqlalchemy/engine/result.py | 1 - 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/sqlalchemy/engine/base.py b/lib/sqlalchemy/engine/base.py index 464d2d2ab3..facb2650e1 100644 --- a/lib/sqlalchemy/engine/base.py +++ b/lib/sqlalchemy/engine/base.py @@ -2437,7 +2437,7 @@ class Connection(ConnectionEventsTarget, inspection.Inspectable["Inspector"]): break if sqlalchemy_exception and is_disconnect != ctx.is_disconnect: - sqlalchemy_exception.connection_invalidated = is_disconnect = ( + sqlalchemy_exception.connection_invalidated = ( ctx.is_disconnect ) diff --git a/lib/sqlalchemy/engine/default.py b/lib/sqlalchemy/engine/default.py index 7d5afa83ef..8b704d2a1b 100644 --- a/lib/sqlalchemy/engine/default.py +++ b/lib/sqlalchemy/engine/default.py @@ -744,8 +744,6 @@ class DefaultDialect(Dialect): raise def do_ping(self, dbapi_connection: DBAPIConnection) -> bool: - cursor = None - cursor = dbapi_connection.cursor() try: cursor.execute(self._dialect_specific_select_one) @@ -1849,7 +1847,7 @@ class DefaultExecutionContext(ExecutionContext): if self.is_crud or self.is_text: result = self._setup_dml_or_text_result() - yp = sr = False + yp = False else: yp = exec_opt.get("yield_per", None) sr = self._is_server_side or exec_opt.get("stream_results", False) diff --git a/lib/sqlalchemy/engine/result.py b/lib/sqlalchemy/engine/result.py index 38db2e1030..2aa0aec9cd 100644 --- a/lib/sqlalchemy/engine/result.py +++ b/lib/sqlalchemy/engine/result.py @@ -811,7 +811,6 @@ class ResultInternal(InPlaceGenerative, Generic[_R]): "was required" ) else: - next_row = _NO_ROW # if we checked for second row then that would have # closed us :) self._soft_close(hard=True) -- 2.47.3