From 7883db2175ed3baefd02d3b2e72fb96c25084ee2 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini Date: Fri, 8 Jul 2011 10:14:38 +0200 Subject: [PATCH] tests: remove redundant settings of `errexit' shell flag * tests/amhello-binpkg.test: Do not set the `errexit' shell flag, as it is already set by `tests/defs'. * tests/amhello-cflags.test: Likewise. * tests/amhello-cross-compile.test: Likewise. * tests/ansi2knr-deprecation.test: Likewise. * tests/autodist-no-duplicate.test: Likewise. * tests/distcheck-configure-flags-am.test: Likewise. * tests/distcheck-configure-flags-subpkg.test: Likewise. * tests/distcheck-configure-flags.test: Likewise. * tests/distcheck-hook.test: Likewise. * tests/distcheck-hook2.test: Likewise. * tests/parallel-tests-am_tests_environment.test: Likewise. * tests/parallel-tests-harderror.test: Likewise. * tests/parallel-tests-log-compiler-example.test: Likewise. * tests/parallel-tests-log-override-1.test: Likewise. * tests/parallel-tests-log-override-2.test: Likewise. * tests/parallel-tests-log-override-recheck.test: Likewise. * tests/primary-prefix-couples-documented-valid.test: Likewise. * tests/primary-prefix-couples-force-valid.test: Likewise. * tests/primary-prefix-invalid-couples.test: Likewise. * tests/primary-prefix-valid-couples.test: Likewise. * tests/remake-subdir-from-subdir.test: Likewise. * tests/remake-subdir-gnu.test: Likewise. * tests/remake-subdir-long-time.test: Likewise. * tests/remake-subdir.test: Likewise. * tests/remake-subdir2.test: Likewise. * tests/silent-configsite.test: Likewise. * tests/tests-environment-backcompat.test: Likewise. --- ChangeLog | 32 +++++++++++++++++++ tests/amhello-binpkg.test | 2 -- tests/amhello-cflags.test | 2 -- tests/amhello-cross-compile.test | 2 -- tests/ansi2knr-deprecation.test | 2 -- tests/autodist-no-duplicate.test | 2 -- tests/distcheck-configure-flags-am.test | 2 -- tests/distcheck-configure-flags-subpkg.test | 2 -- tests/distcheck-configure-flags.test | 2 -- tests/distcheck-hook.test | 2 -- tests/distcheck-hook2.test | 2 -- .../parallel-tests-am_tests_environment.test | 2 -- tests/parallel-tests-harderror.test | 2 -- .../parallel-tests-log-compiler-example.test | 2 -- tests/parallel-tests-log-override-1.test | 2 -- tests/parallel-tests-log-override-2.test | 2 -- .../parallel-tests-log-override-recheck.test | 2 -- ...imary-prefix-couples-documented-valid.test | 2 -- tests/primary-prefix-couples-force-valid.test | 2 -- tests/primary-prefix-invalid-couples.test | 2 -- tests/primary-prefix-valid-couples.test | 2 -- tests/remake-subdir-from-subdir.test | 2 -- tests/remake-subdir-gnu.test | 2 -- tests/remake-subdir-long-time.test | 2 -- tests/remake-subdir.test | 2 -- tests/remake-subdir2.test | 2 -- tests/silent-configsite.test | 2 -- tests/tests-environment-backcompat.test | 2 -- 28 files changed, 32 insertions(+), 54 deletions(-) diff --git a/ChangeLog b/ChangeLog index 9b92575e0..56a1d7c49 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,35 @@ +2011-07-08 Stefano Lattarini + + tests: remove redundant settings of `errexit' shell flag + * tests/amhello-binpkg.test: Do not set the `errexit' shell + flag, as it is already set by `tests/defs'. + * tests/amhello-cflags.test: Likewise. + * tests/amhello-cross-compile.test: Likewise. + * tests/ansi2knr-deprecation.test: Likewise. + * tests/autodist-no-duplicate.test: Likewise. + * tests/distcheck-configure-flags-am.test: Likewise. + * tests/distcheck-configure-flags-subpkg.test: Likewise. + * tests/distcheck-configure-flags.test: Likewise. + * tests/distcheck-hook.test: Likewise. + * tests/distcheck-hook2.test: Likewise. + * tests/parallel-tests-am_tests_environment.test: Likewise. + * tests/parallel-tests-harderror.test: Likewise. + * tests/parallel-tests-log-compiler-example.test: Likewise. + * tests/parallel-tests-log-override-1.test: Likewise. + * tests/parallel-tests-log-override-2.test: Likewise. + * tests/parallel-tests-log-override-recheck.test: Likewise. + * tests/primary-prefix-couples-documented-valid.test: Likewise. + * tests/primary-prefix-couples-force-valid.test: Likewise. + * tests/primary-prefix-invalid-couples.test: Likewise. + * tests/primary-prefix-valid-couples.test: Likewise. + * tests/remake-subdir-from-subdir.test: Likewise. + * tests/remake-subdir-gnu.test: Likewise. + * tests/remake-subdir-long-time.test: Likewise. + * tests/remake-subdir.test: Likewise. + * tests/remake-subdir2.test: Likewise. + * tests/silent-configsite.test: Likewise. + * tests/tests-environment-backcompat.test: Likewise. + 2011-07-08 Stefano Lattarini tests: portability fixes in tests on amhello examples diff --git a/tests/amhello-binpkg.test b/tests/amhello-binpkg.test index 34600fe7e..cb95a0618 100755 --- a/tests/amhello-binpkg.test +++ b/tests/amhello-binpkg.test @@ -19,8 +19,6 @@ . ./defs || Exit 1 -set -e - cp "$testsrcdir"/../doc/amhello-1.0.tar.gz . \ || fatal_ "cannot get amhello tarball" diff --git a/tests/amhello-cflags.test b/tests/amhello-cflags.test index 56f772942..efff153ff 100755 --- a/tests/amhello-cflags.test +++ b/tests/amhello-cflags.test @@ -21,8 +21,6 @@ required=gcc . ./defs || Exit 1 -set -e - cp "$testsrcdir"/../doc/amhello-1.0.tar.gz . \ || fatal_ "cannot get amhello tarball" diff --git a/tests/amhello-cross-compile.test b/tests/amhello-cross-compile.test index 6db91ba9d..bc31243aa 100755 --- a/tests/amhello-cross-compile.test +++ b/tests/amhello-cross-compile.test @@ -20,8 +20,6 @@ required=i586-mingw32msvc-gcc . ./defs || Exit 1 -set -e - cp "$testsrcdir"/../doc/amhello-1.0.tar.gz . \ || fatal_ "cannot get amhello tarball" diff --git a/tests/ansi2knr-deprecation.test b/tests/ansi2knr-deprecation.test index 543d9c62f..c04c6a8e3 100755 --- a/tests/ansi2knr-deprecation.test +++ b/tests/ansi2knr-deprecation.test @@ -19,8 +19,6 @@ . ./defs || Exit 1 -set -e - warn_rx='automatic de-ANSI-fication.*deprecated' cat >> configure.in <<'END' diff --git a/tests/autodist-no-duplicate.test b/tests/autodist-no-duplicate.test index 81464c0f5..1109129f2 100755 --- a/tests/autodist-no-duplicate.test +++ b/tests/autodist-no-duplicate.test @@ -19,8 +19,6 @@ . ./defs || Exit 1 -set -e - re='Files .*automatically distributed.*if found' # The automake manual states that the list of automatically-distributed diff --git a/tests/distcheck-configure-flags-am.test b/tests/distcheck-configure-flags-am.test index a5cab6a50..40c3a7911 100755 --- a/tests/distcheck-configure-flags-am.test +++ b/tests/distcheck-configure-flags-am.test @@ -19,8 +19,6 @@ . ./defs || Exit 1 -set -e - cat >> configure.in << 'END' AC_ARG_ENABLE([success], [], [success=$enableval], [success=no]) AS_IF([test $success = yes && test "$sentence" = 'it works :-)'], diff --git a/tests/distcheck-configure-flags-subpkg.test b/tests/distcheck-configure-flags-subpkg.test index 695b47c19..5c9a3207c 100755 --- a/tests/distcheck-configure-flags-subpkg.test +++ b/tests/distcheck-configure-flags-subpkg.test @@ -22,8 +22,6 @@ . ./defs || Exit 1 -set -e - cat >> configure.in << 'END' AC_CONFIG_SUBDIRS([subpkg]) if test $dc != ok || test $am_dc != ok; then diff --git a/tests/distcheck-configure-flags.test b/tests/distcheck-configure-flags.test index 117d83c0e..9a2eb4c62 100755 --- a/tests/distcheck-configure-flags.test +++ b/tests/distcheck-configure-flags.test @@ -18,8 +18,6 @@ . ./defs || Exit 1 -set -e - cat >> configure.in << 'END' AC_ARG_ENABLE([success], [], [success=$enableval], [success=no]) AS_IF([test $success = yes && test "$sentence" = 'it works :-)'], diff --git a/tests/distcheck-hook.test b/tests/distcheck-hook.test index 9a2c384ad..16b151e13 100755 --- a/tests/distcheck-hook.test +++ b/tests/distcheck-hook.test @@ -18,8 +18,6 @@ . ./defs || Exit 1 -set -e - cat >> configure.in << 'END' AC_OUTPUT END diff --git a/tests/distcheck-hook2.test b/tests/distcheck-hook2.test index befc1d63c..7a2015619 100755 --- a/tests/distcheck-hook2.test +++ b/tests/distcheck-hook2.test @@ -20,8 +20,6 @@ . ./defs || Exit 1 -set -e - cat >> configure.in << 'END' AC_CONFIG_SUBDIRS([subpkg]) AC_OUTPUT diff --git a/tests/parallel-tests-am_tests_environment.test b/tests/parallel-tests-am_tests_environment.test index 072e614d4..eff02a6e9 100755 --- a/tests/parallel-tests-am_tests_environment.test +++ b/tests/parallel-tests-am_tests_environment.test @@ -20,8 +20,6 @@ parallel_tests=yes . ./defs || Exit 1 -set -e - cat >> configure.in << 'END' AC_PROG_MKDIR_P AC_OUTPUT diff --git a/tests/parallel-tests-harderror.test b/tests/parallel-tests-harderror.test index 8680e29c7..dedef36ff 100755 --- a/tests/parallel-tests-harderror.test +++ b/tests/parallel-tests-harderror.test @@ -19,8 +19,6 @@ parallel_tests=yes . ./defs || Exit 1 -set -e - cat >> configure.in << 'END' AC_CONFIG_FILES([sub/Makefile]) AC_OUTPUT diff --git a/tests/parallel-tests-log-compiler-example.test b/tests/parallel-tests-log-compiler-example.test index 746c128d7..95013f1de 100755 --- a/tests/parallel-tests-log-compiler-example.test +++ b/tests/parallel-tests-log-compiler-example.test @@ -21,8 +21,6 @@ parallel_tests=yes required=python . ./defs || Exit 1 -set -e - cat >> configure.in <> configure.in <<'END' AC_OUTPUT END diff --git a/tests/parallel-tests-log-override-2.test b/tests/parallel-tests-log-override-2.test index 649360c90..b790c4199 100755 --- a/tests/parallel-tests-log-override-2.test +++ b/tests/parallel-tests-log-override-2.test @@ -21,8 +21,6 @@ parallel_tests=yes . ./defs || Exit 1 -set -e - cat >> configure.in <<'END' AC_OUTPUT END diff --git a/tests/parallel-tests-log-override-recheck.test b/tests/parallel-tests-log-override-recheck.test index 8a50d293f..0739cbed1 100755 --- a/tests/parallel-tests-log-override-recheck.test +++ b/tests/parallel-tests-log-override-recheck.test @@ -20,8 +20,6 @@ parallel_tests=yes . ./defs || Exit 1 -set -e - cat >> configure.in <<'END' AC_OUTPUT END diff --git a/tests/primary-prefix-couples-documented-valid.test b/tests/primary-prefix-couples-documented-valid.test index 645f318f2..134c21220 100755 --- a/tests/primary-prefix-couples-documented-valid.test +++ b/tests/primary-prefix-couples-documented-valid.test @@ -20,8 +20,6 @@ . ./defs || Exit 1 -set -e - cat >> configure.in <<'END' AC_PROG_CC AC_PROG_RANLIB diff --git a/tests/primary-prefix-couples-force-valid.test b/tests/primary-prefix-couples-force-valid.test index 315ee4ee8..b462a7dd5 100755 --- a/tests/primary-prefix-couples-force-valid.test +++ b/tests/primary-prefix-couples-force-valid.test @@ -26,8 +26,6 @@ required=cc . ./defs || Exit 1 -set -e - cat >> configure.in <<'END' AC_PROG_CC AC_PROG_RANLIB diff --git a/tests/primary-prefix-invalid-couples.test b/tests/primary-prefix-invalid-couples.test index 88e081729..479170703 100755 --- a/tests/primary-prefix-invalid-couples.test +++ b/tests/primary-prefix-invalid-couples.test @@ -22,8 +22,6 @@ . ./defs || Exit 1 -set -e - oIFS=$IFS # Saved for later. : > ltmain.sh diff --git a/tests/primary-prefix-valid-couples.test b/tests/primary-prefix-valid-couples.test index f326808ff..0d0a88c2f 100755 --- a/tests/primary-prefix-valid-couples.test +++ b/tests/primary-prefix-valid-couples.test @@ -19,8 +19,6 @@ . ./defs || Exit 1 -set -e - cat >> configure.in <<'END' AC_PROG_CC AC_PROG_RANLIB diff --git a/tests/remake-subdir-from-subdir.test b/tests/remake-subdir-from-subdir.test index f84455035..8f4a180fd 100755 --- a/tests/remake-subdir-from-subdir.test +++ b/tests/remake-subdir-from-subdir.test @@ -21,8 +21,6 @@ . ./defs || Exit 1 -set -e - cat >> configure.in <<'END' m4_include([subdirs.m4]) AC_SUBST([MAGIC], [magic]) diff --git a/tests/remake-subdir-gnu.test b/tests/remake-subdir-gnu.test index 7865c20d5..bda1ac73d 100755 --- a/tests/remake-subdir-gnu.test +++ b/tests/remake-subdir-gnu.test @@ -23,8 +23,6 @@ required=GNUmake . ./defs || Exit 1 -set -e - magic1='::MagicString::One::' magic2='__MagicString__Two__' diff --git a/tests/remake-subdir-long-time.test b/tests/remake-subdir-long-time.test index 18ba7326e..40f3e5f87 100755 --- a/tests/remake-subdir-long-time.test +++ b/tests/remake-subdir-long-time.test @@ -23,8 +23,6 @@ . ./defs || Exit 1 -set -e - cat > configure.in <> configure.in <<'EOF' AM_SILENT_RULES AC_OUTPUT diff --git a/tests/tests-environment-backcompat.test b/tests/tests-environment-backcompat.test index 6749bc2f2..08daa09d5 100755 --- a/tests/tests-environment-backcompat.test +++ b/tests/tests-environment-backcompat.test @@ -22,8 +22,6 @@ parallel_tests=no . ./defs || Exit 1 -set -e - cat >> configure.in <