From 78de5d28d7207f816565fa43ec44e6735c319ddf Mon Sep 17 00:00:00 2001 From: Daniel Stone Date: Mon, 15 Dec 2025 15:09:17 +0100 Subject: [PATCH] drm/rockchip: vop2: Switch impossible format conditional to WARN_ON We should never be able to create a framebuffer with an unsupported format, so throw a warning if this ever happens. Signed-off-by: Daniel Stone Signed-off-by: Nicolas Frattaroli Signed-off-by: Heiko Stuebner Link: https://patch.msgid.link/20251215-vop2-atomic-fixups-v5-1-83463c075a8d@collabora.com --- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c index 498df0ce4680c..20b49209ddcd5 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c @@ -1030,7 +1030,8 @@ static int vop2_plane_atomic_check(struct drm_plane *plane, return 0; format = vop2_convert_format(fb->format->format); - if (format < 0) + /* We shouldn't be able to create a fb for an unsupported format */ + if (WARN_ON(format < 0)) return format; /* Co-ordinates have now been clipped */ -- 2.47.3