From 7afe1debf47b816878eea0f5feccd7fc21befd77 Mon Sep 17 00:00:00 2001 From: Tom Hromatka Date: Fri, 10 Feb 2023 06:41:50 +0000 Subject: [PATCH] ftests: Add to test to validate cgset's systemd options (cgroup v1) Add a test case to validate cgset tool's systemd options on cgroup legacy and hybrid setup modes. ----------------------------------------------------------------- Test Results: Run Date: Feb 05 12:53:35 Passed: 1 test(s) Skipped: 0 test(s) Failed: 0 test(s) ----------------------------------------------------------------- Timing Results: Test Time (sec) ------------------------------------------- setup 0.00 063-sudo-systemd_cgset-v1.py 2.20 teardown 0.00 ------------------------------------------- Total Run Time 2.20 [Kamalesh improvised on the original test case] Signed-off-by: Kamalesh Babulal Signed-off-by: Tom Hromatka --- tests/ftests/063-sudo-systemd_cgset-v1.py | 137 ++++++++++++++++++++++ tests/ftests/Makefile.am | 1 + 2 files changed, 138 insertions(+) create mode 100755 tests/ftests/063-sudo-systemd_cgset-v1.py diff --git a/tests/ftests/063-sudo-systemd_cgset-v1.py b/tests/ftests/063-sudo-systemd_cgset-v1.py new file mode 100755 index 00000000..bb615bf4 --- /dev/null +++ b/tests/ftests/063-sudo-systemd_cgset-v1.py @@ -0,0 +1,137 @@ +#!/usr/bin/env python3 +# SPDX-License-Identifier: LGPL-2.1-only +# +# Advanced cgset functionality test - '-b' '-g' (cgroup v1) +# +# Copyright (c) 2023 Oracle and/or its affiliates. +# Author: Tom Hromatka +# Author: Kamalesh Babulal + +from cgroup import Cgroup, CgroupVersion +from systemd import Systemd +from run import RunError +import consts +import ftests +import sys +import os + + +CONTROLLER = 'cpu' +SYSTEMD_CGNAME = '063_cg_in_scope' +OTHER_CGNAME = '063_cg_not_in_scope' + +SLICE = 'libcgtests.slice' +SCOPE = 'test063.scope' + +CONFIG_FILE_NAME = os.path.join(os.getcwd(), '063cgconfig.conf') + + +def prereqs(config): + result = consts.TEST_PASSED + cause = None + + if CgroupVersion.get_version('cpu') != CgroupVersion.CGROUP_V1: + result = consts.TEST_SKIPPED + cause = 'This test requires the cgroup v1 cpu controller' + return result, cause + + if config.args.container: + result = consts.TEST_SKIPPED + cause = 'This test cannot be run within a container' + + return result, cause + + +def setup(config): + result = consts.TEST_PASSED + cause = None + + Systemd.write_config_with_pid(config, CONFIG_FILE_NAME, SLICE, SCOPE) + + Cgroup.configparser(config, load_file=CONFIG_FILE_NAME) + + # create and check if the cgroup was created under the systemd default path + if not Cgroup.create_and_validate(config, CONTROLLER, SYSTEMD_CGNAME): + result = consts.TEST_FAILED + cause = ( + 'Failed to create systemd delegated cgroup {} under ' + '/sys/fs/cgroup/{}/{}/{}/'.format(SYSTEMD_CGNAME, CONTROLLER, SLICE, SCOPE) + ) + return result, cause + + # create and check if the cgroup was created under the controller root + if not Cgroup.create_and_validate(config, CONTROLLER, OTHER_CGNAME, ignore_systemd=True): + result = consts.TEST_FAILED + cause = ( + 'Failed to create cgroup {} under ' + '/sys/fs/cgroup/{}/'.format(OTHER_CGNAME, CONTROLLER) + ) + + return result, cause + + +def test(config): + result = consts.TEST_PASSED + cause = None + + Cgroup.set_and_validate(config, SYSTEMD_CGNAME, 'cpu.shares', '200') + Cgroup.set_and_validate(config, OTHER_CGNAME, 'cpu.shares', '300', ignore_systemd=True) + + try: + Cgroup.set(config, SYSTEMD_CGNAME, 'cpu.shares', '400', ignore_systemd=True) + except RunError as re: + if 'requested group parameter does not exist' not in re.stderr: + raise re + else: + result = consts.TEST_FAILED + cause = 'Setting cpu.shares on {} erroneously succeeded'.format(SYSTEMD_CGNAME) + + try: + Cgroup.set(config, OTHER_CGNAME, 'cpu.shares', '500') + except RunError as re: + if 'requested group parameter does not exist' not in re.stderr: + raise re + else: + result = consts.TEST_FAILED + tmp_cause = 'Setting cpu.shares on {} erroneously succeeded'.format(OTHER_CGNAME) + cause = '\n'.join(filter(None, [cause, tmp_cause])) + + return result, cause + + +def teardown(config): + Systemd.remove_scope_slice_conf(config, SLICE, SCOPE, CONTROLLER, CONFIG_FILE_NAME) + + # Incase the error occurs before the creation of OTHER_CGNAME, + # let's ignore the exception + try: + Cgroup.delete(config, CONTROLLER, OTHER_CGNAME, ignore_systemd=True) + except RunError as re: + if 'No such file or directory' in re.stderr: + raise re + + +def main(config): + [result, cause] = prereqs(config) + if result != consts.TEST_PASSED: + return [result, cause] + + [result, cause] = setup(config) + if result != consts.TEST_PASSED: + return [result, cause] + + try: + [result, cause] = test(config) + finally: + teardown(config) + + return [result, cause] + + +if __name__ == '__main__': + config = ftests.parse_args() + # this test was invoked directly. run only it + config.args.num = int(os.path.basename(__file__).split('-')[0]) + sys.exit(ftests.main(config)) + +# vim: set et ts=4 sw=4: diff --git a/tests/ftests/Makefile.am b/tests/ftests/Makefile.am index 5d0d0e22..2e2fcd08 100644 --- a/tests/ftests/Makefile.am +++ b/tests/ftests/Makefile.am @@ -83,6 +83,7 @@ EXTRA_DIST_PYTHON_TESTS = \ 060-sudo-cgconfigparser-systemd.py \ 061-sudo-g_flag_controller_only_systemd-v1.py \ 062-sudo-g_flag_controller_only_systemd-v2.py \ + 063-sudo-systemd_cgset-v1.py \ 098-cgdelete-non-existing-shared-mnt-cgroup-v1.py # Intentionally omit the stress test from the extra dist # 999-stress-cgroup_init.py -- 2.47.2