From 7bd16d416db010e7140313fe326861cc263b8864 Mon Sep 17 00:00:00 2001 From: layday Date: Sun, 19 Sep 2021 14:54:54 +0300 Subject: [PATCH] Relax the Python version check for `__class_getitem__` tests `__class_getitem__` to support generics was introduced in Python 3.7. In 3.9 some built-ins were made generic but the functionality for user-defined classes has been there since 3.7. --- lib/sqlalchemy/testing/requirements.py | 6 +++--- test/base/test_misc_py3k.py | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/sqlalchemy/testing/requirements.py b/lib/sqlalchemy/testing/requirements.py index 40127addfb..f6e79042c9 100644 --- a/lib/sqlalchemy/testing/requirements.py +++ b/lib/sqlalchemy/testing/requirements.py @@ -1448,6 +1448,6 @@ class SuiteRequirements(Requirements): return exclusions.open() @property - def builtin_generics(self): - "If list[int] is a valid syntax. basically py3.9+" - return exclusions.only_if(lambda: util.py39) + def generic_classes(self): + "If X[Y] can be implemented with ``__class_getitem__``. py3.7+" + return exclusions.only_if(lambda: util.py37) diff --git a/test/base/test_misc_py3k.py b/test/base/test_misc_py3k.py index 3cd9e1af49..11e7b9edda 100644 --- a/test/base/test_misc_py3k.py +++ b/test/base/test_misc_py3k.py @@ -4,7 +4,7 @@ from sqlalchemy.testing import requires class TestGenerics(fixtures.TestBase): - @requires.builtin_generics + @requires.generic_classes def test_traversible_is_generic(self): col = Column[int] assert col is Column -- 2.47.3