From 7d3ca9dbdd0a226f3440c2d19c89cf5937b88f3f Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Fri, 9 Apr 2021 15:59:42 +0200 Subject: [PATCH] qemuhotplugtest: Add also always-present capabilities Use virQEMUCapsInitQMPBasicArch in qemuHotplugCreateObjects so that we also add the always-present capabilities to the set of capabilities used for the hotplug test and fix fallout. Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina Reviewed-by: Neal Gompa Reviewed-by: Pavel Hrdina --- tests/qemuhotplugtest.c | 5 +++++ .../qemuhotplugtestcpus/ppc64-modern-bulk-result-conf.xml | 2 +- .../qemuhotplugtestcpus/ppc64-modern-bulk-result-live.xml | 2 +- .../ppc64-modern-individual-result-conf.xml | 2 +- .../ppc64-modern-individual-result-live.xml | 2 +- tests/qemuhotplugtestcpus/x86-modern-bulk-result-conf.xml | 2 +- tests/qemuhotplugtestcpus/x86-modern-bulk-result-live.xml | 2 +- .../x86-modern-individual-add-result-conf.xml | 2 +- .../x86-modern-individual-add-result-live.xml | 2 +- tests/qemuhotplugtestcpus/x86-old-bulk-result-conf.xml | 2 +- tests/qemuhotplugtestcpus/x86-old-bulk-result-live.xml | 2 +- .../qemuhotplug-ivshmem-doorbell-detach.xml | 2 +- .../qemuhotplug-ivshmem-plain-detach.xml | 2 +- .../qemuhotplugtestdevices/qemuhotplug-watchdog-full.xml | 2 +- .../qemuhotplug-watchdog-user-alias-full.xml | 2 +- .../qemuhotplug-base-live+disk-virtio.xml | 2 +- .../qemuhotplug-base-live+hostdev-pci.xml | 2 +- .../qemuhotplug-base-live+interface-vdpa.xml | 2 +- .../qemuhotplug-base-live+ivshmem-doorbell.xml | 4 ++-- .../qemuhotplug-base-live+ivshmem-plain.xml | 2 +- .../qemuhotplug-base-live+watchdog-user-alias.xml | 2 +- .../qemuhotplug-base-live+watchdog.xml | 2 +- .../qemuhotplug-base-with-scsi-controller-live.xml | 8 ++++---- ...plug-base-without-scsi-controller-live+disk-scsi-2.xml | 8 ++++---- 24 files changed, 35 insertions(+), 30 deletions(-) diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c index cb29d62aff..57d76845c6 100644 --- a/tests/qemuhotplugtest.c +++ b/tests/qemuhotplugtest.c @@ -32,6 +32,9 @@ #include "virthread.h" #include "virfile.h" +#define LIBVIRT_QEMU_CAPSPRIV_H_ALLOW +#include "qemu/qemu_capspriv.h" + #define VIR_FROM_THIS VIR_FROM_NONE static virQEMUDriver driver; @@ -71,6 +74,8 @@ qemuHotplugCreateObjects(virDomainXMLOption *xmlopt, if (!(priv->qemuCaps = virQEMUCapsNew())) return -1; + virQEMUCapsInitQMPBasicArch(priv->qemuCaps); + virQEMUCapsSet(priv->qemuCaps, QEMU_CAPS_VIRTIO_SCSI); virQEMUCapsSet(priv->qemuCaps, QEMU_CAPS_DEVICE_USB_STORAGE); virQEMUCapsSet(priv->qemuCaps, QEMU_CAPS_CCW); diff --git a/tests/qemuhotplugtestcpus/ppc64-modern-bulk-result-conf.xml b/tests/qemuhotplugtestcpus/ppc64-modern-bulk-result-conf.xml index 690c85cf85..a7ada18bf3 100644 --- a/tests/qemuhotplugtestcpus/ppc64-modern-bulk-result-conf.xml +++ b/tests/qemuhotplugtestcpus/ppc64-modern-bulk-result-conf.xml @@ -59,7 +59,7 @@