From 7f508ff96858e61bf216e749e09bb0dbdcbaf66e Mon Sep 17 00:00:00 2001 From: Johannes Berg Date: Thu, 7 May 2020 10:26:50 +0200 Subject: [PATCH] tests: Reset the correct key's PN for group key handshake testing While adding support for IGTK and BIGTK here, I tested this without protections (i.e., with protections removed from both wpa_supplicant and the driver), and while I got some bad resets on the debugfs values, it should have failed with "unexpected connectivity". Fix this to be correct - we need to reset the GTK PN, not the PTK PN in this test. Signed-off-by: Johannes Berg --- tests/hwsim/test_ap_ciphers.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/hwsim/test_ap_ciphers.py b/tests/hwsim/test_ap_ciphers.py index 482fba18f..352830a04 100644 --- a/tests/hwsim/test_ap_ciphers.py +++ b/tests/hwsim/test_ap_ciphers.py @@ -853,7 +853,7 @@ def run_ap_wpa2_delayed_group_m1_retransmission(dev, apdev): time.sleep(0.1) after = get_rx_spec(phy, keytype=KT_GTK).splitlines() - if "OK" not in hapd.request("RESET_PN " + addr): + if "OK" not in hapd.request("RESET_PN ff:ff:ff:ff:ff:ff"): raise Exception("RESET_PN failed") time.sleep(0.1) hwsim_utils.test_connectivity(dev[0], hapd, timeout=1, -- 2.47.2