From 7ff2e7070a4fb021de83eec0eb8ae05de02d6fbb Mon Sep 17 00:00:00 2001 From: Federico Caselli Date: Fri, 23 May 2025 23:10:43 +0200 Subject: [PATCH] fix missing quotes from cast call in mysqlconnector module This fixes an issue introduced by 51a7678db2f0fcb1552afa40333640bc7fbb6dac in I37bd98049ff1a64d58e9490b0e5e2ea764dd1f73 Change-Id: Id738c04ee4dc8c2b12d9ab0fc71a4e1a6c5bc209 (cherry picked from commit 1070889f263be89e0e47bdbb9f7113e98ead192b) --- lib/sqlalchemy/dialects/mysql/base.py | 4 ++-- lib/sqlalchemy/dialects/mysql/mysqlconnector.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/sqlalchemy/dialects/mysql/base.py b/lib/sqlalchemy/dialects/mysql/base.py index def897edf9..be49a7e762 100644 --- a/lib/sqlalchemy/dialects/mysql/base.py +++ b/lib/sqlalchemy/dialects/mysql/base.py @@ -3690,7 +3690,7 @@ class MySQLDialect(default.DefaultDialect): if not row: return None else: - return cast("Optional[str]", row[fetch_col]) + return cast(Optional[str], row[fetch_col]) def _detect_charset(self, connection: Connection) -> str: raise NotImplementedError() @@ -3803,7 +3803,7 @@ class MySQLDialect(default.DefaultDialect): row = self._compat_first(rp, charset=charset) if not row: raise exc.NoSuchTableError(full_name) - return cast("str", row[1]).strip() + return cast(str, row[1]).strip() @overload def _describe_table( diff --git a/lib/sqlalchemy/dialects/mysql/mysqlconnector.py b/lib/sqlalchemy/dialects/mysql/mysqlconnector.py index ad2e4856e1..91d1058e9c 100644 --- a/lib/sqlalchemy/dialects/mysql/mysqlconnector.py +++ b/lib/sqlalchemy/dialects/mysql/mysqlconnector.py @@ -162,7 +162,7 @@ class MySQLDialect_mysqlconnector(MySQLDialect): @classmethod def import_dbapi(cls) -> DBAPIModule: - return cast(DBAPIModule, __import__("mysql.connector").connector) + return cast("DBAPIModule", __import__("mysql.connector").connector) def do_ping(self, dbapi_connection: DBAPIConnection) -> bool: dbapi_connection.ping(False) -- 2.47.2