From 80b4b1e740de60a7f94132ac4bebcd9474fbe182 Mon Sep 17 00:00:00 2001 From: Gert Doering Date: Mon, 11 Mar 2013 21:03:20 +0100 Subject: [PATCH] Repair "tcp server queue overflow" brokenness, more fallout. Return value of mbuf_len() wrong - it's returning a length value, not a yes/no value - so when the queue length approached 65 (full!), it still only returned "1", leading to MBUF overflow later on. Change from "bool" to "unsigned int", misbehaviour gone... This fixes OpenVPN trac ticket #263. Signed-off-by: Gert Doering Acked-by: Arne Schwabe Acked-by: Peter Caprioli Message-Id: <20130312100706.GN953@greenie.muc.de> URL: http://article.gmane.org/gmane.network.openvpn.devel/7396 Signed-off-by: Gert Doering (cherry picked from commit 0eb398501fab9c016b9b6008682c43873c4a6188) --- src/openvpn/mbuf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/mbuf.h b/src/openvpn/mbuf.h index a0de679d0..1085adc7c 100644 --- a/src/openvpn/mbuf.h +++ b/src/openvpn/mbuf.h @@ -83,7 +83,7 @@ mbuf_defined (const struct mbuf_set *ms) return ms && ms->len; } -static inline bool +static inline unsigned int mbuf_len (const struct mbuf_set *ms) { return ms->len; -- 2.47.2