From 81140d6b739a319c583f32cfb076d870262d6a51 Mon Sep 17 00:00:00 2001 From: Marcin Siodelski Date: Wed, 19 Dec 2018 13:40:59 +0100 Subject: [PATCH] [#99,!176] Updated commentary in the test config backend for DHCPv4. --- src/lib/dhcpsrv/testutils/test_config_backend.h | 3 ++- .../dhcpsrv/testutils/test_config_backend_dhcp4.h | 14 ++++++-------- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/src/lib/dhcpsrv/testutils/test_config_backend.h b/src/lib/dhcpsrv/testutils/test_config_backend.h index 7c644eb9f1..b82cc00b6a 100644 --- a/src/lib/dhcpsrv/testutils/test_config_backend.h +++ b/src/lib/dhcpsrv/testutils/test_config_backend.h @@ -52,7 +52,8 @@ public: /// @brief Returns backend type. /// /// @return string db_type name - virtual std::string getType() const { return (db_type_); + virtual std::string getType() const { + return (db_type_); } /// @brief Returns backend host. diff --git a/src/lib/dhcpsrv/testutils/test_config_backend_dhcp4.h b/src/lib/dhcpsrv/testutils/test_config_backend_dhcp4.h index 34cb9fd8a9..bd2aba62dc 100644 --- a/src/lib/dhcpsrv/testutils/test_config_backend_dhcp4.h +++ b/src/lib/dhcpsrv/testutils/test_config_backend_dhcp4.h @@ -14,7 +14,6 @@ #include #include -#include #include #include @@ -23,19 +22,18 @@ namespace isc { namespace dhcp { namespace test { -/// @brief Test backend that implements all of the DHCPv4 API calls +/// @brief Test config backend that implements all of the DHCPv4 API calls /// -/// Currently all API get calls which return a single entry, will return an -/// empty pointer of appropriate type. API calls which return a collection of -/// entires will return an empty collection of the appropriate type. +/// This backend should be used for unit testing the DHCPv4 server and the +/// commands which manpiluate the configuration information stored in the +/// database. /// -/// In addition provides static register and unregister methods so it may be -/// registered with a configuration backend manager. +/// This backend stores server configuration information in memory. class TestConfigBackendDHCPv4 : public TestConfigBackend { public: /// @brief Constructor /// - /// + /// @param params Database connection parameters. TestConfigBackendDHCPv4(const db::DatabaseConnection::ParameterMap& params) : TestConfigBackend(params) { } -- 2.47.2