From 814cbd56981642f55f24caf2532e250c5ae8690e Mon Sep 17 00:00:00 2001
From: =?utf8?q?P=C3=A1draig=20Brady?= <P@draigBrady.com>
Date: Thu, 16 Sep 2021 12:21:16 +0100
Subject: [PATCH] tests: ensure returns_ check failures are propagated

* tests/misc/cksum-a.sh: Set fail=1 if returns_ check fails.
* tests/misc/sync.sh: Likewise.
* tests/misc/yes.sh: Likewise.
---
 tests/misc/cksum-a.sh | 4 ++--
 tests/misc/sync.sh    | 2 +-
 tests/misc/yes.sh     | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/misc/cksum-a.sh b/tests/misc/cksum-a.sh
index 92d84203d3..3bd41dbe5f 100755
--- a/tests/misc/cksum-a.sh
+++ b/tests/misc/cksum-a.sh
@@ -47,7 +47,7 @@ while read algo prog; do
 done < input_options
 compare out out-a || fail=1
 
-returns_ 1 cksum -a bsd --tag </dev/null
-returns_ 1 cksum -a bsd --check </dev/null
+returns_ 1 cksum -a bsd --tag </dev/null || fail=1
+returns_ 1 cksum -a bsd --check </dev/null || fail=1
 
 Exit $fail
diff --git a/tests/misc/sync.sh b/tests/misc/sync.sh
index 6f700c5426..bf0bdf1183 100755
--- a/tests/misc/sync.sh
+++ b/tests/misc/sync.sh
@@ -42,7 +42,7 @@ returns_ 1 sync file nofile || fail=1
 mkdir norw || framework_failure_
 chmod 0 norw || framework_failure_
 if ! test -r norw; then
-  returns_ 1 sync norw 2>errt
+  returns_ 1 sync norw 2>errt || fail=1
   # AIX gives "Is a directory"
   sed 's/Is a directory/Permission denied/' <errt >err || framework_failure_
   printf "sync: error opening 'norw': Permission denied\n" >exp
diff --git a/tests/misc/yes.sh b/tests/misc/yes.sh
index 2a8b7d5753..70de5afe08 100755
--- a/tests/misc/yes.sh
+++ b/tests/misc/yes.sh
@@ -50,7 +50,7 @@ if test -w /dev/full && test -c /dev/full; then
   printf '%s\n' "yes: standard output" > exp
 
   for size in 1 16384; do
-    returns_ 1 yes "$(printf %${size}s '')" >/dev/full 2>errt
+    returns_ 1 yes "$(printf %${size}s '')" >/dev/full 2>errt || fail=1
     sed 's/\(yes:.*\):.*/\1/' errt > err
     compare exp err || fail=1
   done
-- 
2.47.2