From 8257e6c49cca9847e01262f6e749c6e88e2ddb72 Mon Sep 17 00:00:00 2001 From: Aya Levin Date: Thu, 28 Feb 2019 14:12:56 +0200 Subject: [PATCH] devlink: Fix boolean JSON print This patch removes the inverted commas from boolean values in JSON format: true/false instead of "true"/"false". Signed-off-by: Aya Levin Reviewed-by: Moshe Shemesh Acked-by: Jiri Pirko Signed-off-by: David Ahern --- devlink/devlink.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/devlink/devlink.c b/devlink/devlink.c index 8a28b5d5c..4b7e8ec2c 100644 --- a/devlink/devlink.c +++ b/devlink/devlink.c @@ -1628,10 +1628,10 @@ static void pr_out_str(struct dl *dl, const char *name, const char *val) static void pr_out_bool(struct dl *dl, const char *name, bool val) { - if (val) - pr_out_str(dl, name, "true"); + if (dl->json_output) + jsonw_bool_field(dl->jw, name, val); else - pr_out_str(dl, name, "false"); + pr_out_str(dl, name, val ? "true" : "false"); } static void pr_out_uint(struct dl *dl, const char *name, unsigned int val) -- 2.47.2