From 82d7ffb07c81aefeabf67c7c066070efbc34400b Mon Sep 17 00:00:00 2001 From: Greg Hudson Date: Mon, 9 Dec 2019 11:33:57 -0500 Subject: [PATCH] Fix error return case in serialization code One of the changes in commit 81e47875e3de0e52fbb11d61ef30a9406497af73 unintentionally caused the return value of profile_ser_externalize() to be ignored. --- src/lib/krb5/krb/ser_ctx.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/lib/krb5/krb/ser_ctx.c b/src/lib/krb5/krb/ser_ctx.c index 80cd05640c..9d5f9dedfa 100644 --- a/src/lib/krb5/krb/ser_ctx.c +++ b/src/lib/krb5/krb/ser_ctx.c @@ -204,8 +204,11 @@ k5_externalize_context(krb5_context context, return (kret); /* Finally, handle profile, if appropriate */ - if (context->profile != NULL) + if (context->profile != NULL) { kret = profile_ser_externalize(NULL, context->profile, &bp, &remain); + if (kret) + return (kret); + } /* * If we were successful, write trailer then update the pointer and -- 2.47.2