From 83ba6efa711fad83a0fbf02178ad64d3906d8d09 Mon Sep 17 00:00:00 2001 From: Mark Brown Date: Fri, 16 Jan 2026 13:23:40 +0000 Subject: [PATCH] spi: rockchip: Use plain request_irq() The Rockchip driver has since interrupt support was added used request_threaded_irq() but not actually supplied a threaded handler, handling everything in the primary handler. This is equivalent to just using a plain request_irq(), and since aef30c8d569c (genirq: Warn about using IRQF_ONESHOT without a threaded handler) the current behaviour has triggered a WARN_ON(). Convert to use request_irq(). Reported-by: Aishwarya TCV Reviewed-by: Shawn Lin Signed-off-by: Mark Brown Link: https://patch.msgid.link/20260116-spi-rockchip-threaded-irq-v1-1-c45c3a5a38b1@kernel.org Signed-off-by: Mark Brown --- drivers/spi/spi-rockchip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c index 1a6381de6f33d..62e1bc08c940f 100644 --- a/drivers/spi/spi-rockchip.c +++ b/drivers/spi/spi-rockchip.c @@ -805,8 +805,8 @@ static int rockchip_spi_probe(struct platform_device *pdev) if (ret < 0) goto err_put_ctlr; - ret = devm_request_threaded_irq(&pdev->dev, ret, rockchip_spi_isr, NULL, - IRQF_ONESHOT, dev_name(&pdev->dev), ctlr); + ret = devm_request_irq(&pdev->dev, ret, rockchip_spi_isr, 0, + dev_name(&pdev->dev), ctlr); if (ret) goto err_put_ctlr; -- 2.47.3