From 83ed5d58d2c767d03ce97aef484863a6e1c37a94 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= Date: Wed, 18 Jul 2018 14:25:26 +0200 Subject: [PATCH] BUG/MINOR: lua: Bad HTTP client request duration. HTTP LUA applet callback should not update the date on which the HTTP client requests arrive. This was done just after the LUA applet has completed its job. This patch simply removes the affected statement. The same fixe has been applied to TCP LUA applet callback. To reproduce this issue, as reported by Patrick Hemmer, implement an HTTP LUA applet which sleeps a bit before replying: core.register_service("foo", "http", function(applet) core.msleep(100) applet:set_status(200) applet:start_response() end) This had as a consequence to log %TR field with approximatively the same value as the LUA sleep time. Thank you to Patrick Hemmer for having reported this issue. Must be backported to 1.8, 1.7 and 1.6. --- src/hlua.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/hlua.c b/src/hlua.c index 65986473a0..edb4f68cac 100644 --- a/src/hlua.c +++ b/src/hlua.c @@ -6459,9 +6459,6 @@ static void hlua_applet_tcp_fct(struct appctx *ctx) case HLUA_E_OK: ctx->ctx.hlua_apptcp.flags |= APPLET_DONE; - /* log time */ - strm->logs.tv_request = now; - /* eat the whole request */ co_skip(si_oc(si), co_data(si_oc(si))); res->flags |= CF_READ_NULL; @@ -6790,9 +6787,8 @@ static void hlua_applet_http_fct(struct appctx *ctx) /* close the connection. */ - /* status / log */ + /* status */ strm->txn->status = ctx->ctx.hlua_apphttp.status; - strm->logs.tv_request = now; /* eat the whole request */ co_skip(si_oc(si), co_data(si_oc(si))); -- 2.39.5