From 85a954cebbbb3ae6210a779a5f3b29559ec5f862 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Guido=20G=C3=BCnther?= Date: Sat, 23 Jul 2011 23:24:21 +0200 Subject: [PATCH] Catch dnsmasq start failures While we checked the return value we didn't maks sure ret != 0 which resulted in dnsmasq errors being ignored. --- src/network/bridge_driver.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index f242db8c05..a21b538a5d 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -745,8 +745,10 @@ networkStartDhcpDaemon(virNetworkObjPtr network) if (ret < 0) goto cleanup; - if (virCommandRun(cmd, NULL) < 0) + ret = virCommandRun(cmd, NULL); + if (ret < 0) { goto cleanup; + } /* * There really is no race here - when dnsmasq daemonizes, its -- 2.47.2