From 85f3592725e18316762abb86dd521ebf10ad22e3 Mon Sep 17 00:00:00 2001 From: Evan You Date: Wed, 24 Apr 2024 17:27:51 +0800 Subject: [PATCH] refactor: should throw errors in computed getters --- packages/reactivity/src/effect.ts | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/packages/reactivity/src/effect.ts b/packages/reactivity/src/effect.ts index 90db99cf77..e361e85404 100644 --- a/packages/reactivity/src/effect.ts +++ b/packages/reactivity/src/effect.ts @@ -375,12 +375,13 @@ export function refreshComputed(computed: ComputedRefImpl) { } } catch (err) { dep.version++ + throw err + } finally { + activeSub = prevSub + shouldTrack = prevShouldTrack + cleanupDeps(computed) + computed.flags &= ~EffectFlags.RUNNING } - - activeSub = prevSub - shouldTrack = prevShouldTrack - cleanupDeps(computed) - computed.flags &= ~EffectFlags.RUNNING } function removeSub(link: Link) { -- 2.47.2