From 8607dc37063a0d4965c3458db1e3d6c37f1ba4bb Mon Sep 17 00:00:00 2001 From: Michal Privoznik Date: Fri, 15 Oct 2021 10:56:34 +0200 Subject: [PATCH] qemuxml2argvtest: Drop negative virtio-*-ats tests There are some tests cases in qemuxml2argvtest that aim to check whether our validator rejects when QEMU_CAPS_VIRTIO_PCI_ATS capability is not present. Well, such scenario can't happen really because the capability will always be present. Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- .../virtio-options-controller-ats.err | 1 - tests/qemuxml2argvdata/virtio-options-disk-ats.err | 1 - tests/qemuxml2argvdata/virtio-options-fs-ats.err | 1 - tests/qemuxml2argvdata/virtio-options-input-ats.err | 1 - .../virtio-options-memballoon-ats.err | 1 - tests/qemuxml2argvdata/virtio-options-net-ats.err | 1 - tests/qemuxml2argvdata/virtio-options-rng-ats.err | 1 - tests/qemuxml2argvdata/virtio-options-video-ats.err | 1 - tests/qemuxml2argvtest.c | 13 ------------- 9 files changed, 21 deletions(-) delete mode 100644 tests/qemuxml2argvdata/virtio-options-controller-ats.err delete mode 100644 tests/qemuxml2argvdata/virtio-options-disk-ats.err delete mode 100644 tests/qemuxml2argvdata/virtio-options-fs-ats.err delete mode 100644 tests/qemuxml2argvdata/virtio-options-input-ats.err delete mode 100644 tests/qemuxml2argvdata/virtio-options-memballoon-ats.err delete mode 100644 tests/qemuxml2argvdata/virtio-options-net-ats.err delete mode 100644 tests/qemuxml2argvdata/virtio-options-rng-ats.err delete mode 100644 tests/qemuxml2argvdata/virtio-options-video-ats.err diff --git a/tests/qemuxml2argvdata/virtio-options-controller-ats.err b/tests/qemuxml2argvdata/virtio-options-controller-ats.err deleted file mode 100644 index f1ae0949f6..0000000000 --- a/tests/qemuxml2argvdata/virtio-options-controller-ats.err +++ /dev/null @@ -1 +0,0 @@ -unsupported configuration: the ats setting is not supported with this QEMU binary diff --git a/tests/qemuxml2argvdata/virtio-options-disk-ats.err b/tests/qemuxml2argvdata/virtio-options-disk-ats.err deleted file mode 100644 index f1ae0949f6..0000000000 --- a/tests/qemuxml2argvdata/virtio-options-disk-ats.err +++ /dev/null @@ -1 +0,0 @@ -unsupported configuration: the ats setting is not supported with this QEMU binary diff --git a/tests/qemuxml2argvdata/virtio-options-fs-ats.err b/tests/qemuxml2argvdata/virtio-options-fs-ats.err deleted file mode 100644 index f1ae0949f6..0000000000 --- a/tests/qemuxml2argvdata/virtio-options-fs-ats.err +++ /dev/null @@ -1 +0,0 @@ -unsupported configuration: the ats setting is not supported with this QEMU binary diff --git a/tests/qemuxml2argvdata/virtio-options-input-ats.err b/tests/qemuxml2argvdata/virtio-options-input-ats.err deleted file mode 100644 index f1ae0949f6..0000000000 --- a/tests/qemuxml2argvdata/virtio-options-input-ats.err +++ /dev/null @@ -1 +0,0 @@ -unsupported configuration: the ats setting is not supported with this QEMU binary diff --git a/tests/qemuxml2argvdata/virtio-options-memballoon-ats.err b/tests/qemuxml2argvdata/virtio-options-memballoon-ats.err deleted file mode 100644 index f1ae0949f6..0000000000 --- a/tests/qemuxml2argvdata/virtio-options-memballoon-ats.err +++ /dev/null @@ -1 +0,0 @@ -unsupported configuration: the ats setting is not supported with this QEMU binary diff --git a/tests/qemuxml2argvdata/virtio-options-net-ats.err b/tests/qemuxml2argvdata/virtio-options-net-ats.err deleted file mode 100644 index f1ae0949f6..0000000000 --- a/tests/qemuxml2argvdata/virtio-options-net-ats.err +++ /dev/null @@ -1 +0,0 @@ -unsupported configuration: the ats setting is not supported with this QEMU binary diff --git a/tests/qemuxml2argvdata/virtio-options-rng-ats.err b/tests/qemuxml2argvdata/virtio-options-rng-ats.err deleted file mode 100644 index f1ae0949f6..0000000000 --- a/tests/qemuxml2argvdata/virtio-options-rng-ats.err +++ /dev/null @@ -1 +0,0 @@ -unsupported configuration: the ats setting is not supported with this QEMU binary diff --git a/tests/qemuxml2argvdata/virtio-options-video-ats.err b/tests/qemuxml2argvdata/virtio-options-video-ats.err deleted file mode 100644 index f1ae0949f6..0000000000 --- a/tests/qemuxml2argvdata/virtio-options-video-ats.err +++ /dev/null @@ -1 +0,0 @@ -unsupported configuration: the ats setting is not supported with this QEMU binary diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 595bc6e06c..a0ee5f9943 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -3279,19 +3279,6 @@ mymain(void) DO_TEST_CAPS_LATEST("virtio-options-net-packed"); DO_TEST_CAPS_LATEST("virtio-options-rng-packed"); DO_TEST_CAPS_LATEST("virtio-options-video-packed"); - DO_TEST_PARSE_ERROR("virtio-options-controller-ats", QEMU_CAPS_VIRTIO_SCSI); - DO_TEST_PARSE_ERROR_NOCAPS("virtio-options-disk-ats"); - DO_TEST_PARSE_ERROR_NOCAPS("virtio-options-fs-ats"); - DO_TEST_PARSE_ERROR("virtio-options-input-ats", QEMU_CAPS_VIRTIO_MOUSE, - QEMU_CAPS_VIRTIO_KEYBOARD); - DO_TEST_PARSE_ERROR_NOCAPS("virtio-options-memballoon-ats"); - DO_TEST_PARSE_ERROR_NOCAPS("virtio-options-net-ats"); - DO_TEST_PARSE_ERROR("virtio-options-rng-ats", QEMU_CAPS_DEVICE_VIRTIO_RNG, - QEMU_CAPS_OBJECT_RNG_RANDOM); - DO_TEST_PARSE_ERROR("virtio-options-video-ats", QEMU_CAPS_DEVICE_VIRTIO_GPU, - QEMU_CAPS_DEVICE_VIRTIO_GPU, - QEMU_CAPS_VIRTIO_GPU_VIRGL, - QEMU_CAPS_DEVICE_VHOST_USER_GPU); DO_TEST_PARSE_ERROR("virtio-options-controller-packed", QEMU_CAPS_VIRTIO_SCSI); DO_TEST_PARSE_ERROR_NOCAPS("virtio-options-disk-packed"); DO_TEST_PARSE_ERROR_NOCAPS("virtio-options-fs-packed"); -- 2.47.2