From 86823c828f983bd986b150542c7a6482d60b291d Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Fri, 6 Dec 2024 17:30:05 +0100 Subject: [PATCH] MINOR: mux-h2/traces: add a missing trace on negative initial window size When a negative initial windows size is reported, we're going to close the connection, so it's important to report a trace to explain why! This should be backported at least to 3.1 and possibly 3.0 (adapting the context since there's no glitches there). --- src/mux_h2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mux_h2.c b/src/mux_h2.c index 4479a311c1..faea974d66 100644 --- a/src/mux_h2.c +++ b/src/mux_h2.c @@ -2667,6 +2667,7 @@ static int h2c_handle_settings(struct h2c *h2c) if (arg < 0) { // RFC7540#6.5.2 error = H2_ERR_FLOW_CONTROL_ERROR; h2c_report_glitch(h2c, 1); + TRACE_STATE("negative INITIAL_WINDOW_SIZE", H2_EV_RX_FRAME|H2_EV_RX_SETTINGS|H2_EV_H2C_ERR|H2_EV_PROTO_ERR, h2c->conn); goto fail; } /* Let's count a glitch here in case of a reduction -- 2.39.5