From 8694a0523e48270869f2b48dab860d152d58da97 Mon Sep 17 00:00:00 2001 From: Paul Gerber Date: Mon, 24 Nov 2025 08:55:24 +0100 Subject: [PATCH] board: tqma6: style fixes fix checkpatch warnings - WARNING: break is not useful after a return - WARNING: Comparisons should place the constant on the right side of the test - WARNING: please write a help paragraph that fully describes the config symbol with at least 2 lines Signed-off-by: Paul Gerber Signed-off-by: Max Merchel --- board/tq/tqma6/Kconfig | 23 +++++++++++++++-------- board/tq/tqma6/tqma6.c | 5 ----- board/tq/tqma6/tqma6_mba6.c | 2 +- 3 files changed, 16 insertions(+), 14 deletions(-) diff --git a/board/tq/tqma6/Kconfig b/board/tq/tqma6/Kconfig index b42c8e24ade..599b3a72f70 100644 --- a/board/tq/tqma6/Kconfig +++ b/board/tq/tqma6/Kconfig @@ -13,26 +13,29 @@ choice prompt "TQMa6 SoC variant" default TQMA6Q help - select the TQMa6 module variant. The variants differing in the used + select the TQMa6 module variant. The variants only differ in the used i.MX6 CPU type and DRAM config TQMA6Q bool "TQMa6Q / TQMa6D" depends on MX6Q help - select TQMa6Q / TQMa6D with i.MX6Q/D and 1GiB DRAM + select TQMa6Q / TQMa6D variant with i.MX6Q resp. i.MX6D + with 1GiB DRAM config TQMA6DL bool "TQMa6DL" depends on MX6DL help - select TQMa6DL with i.MX6DL and 1GiB DRAM + select TQMa6DL variant with i.MX6DL + with 1GiB DRAM config TQMA6S bool "TQMa6S" depends on MX6S help - select TQMa6S with i.MX6S and 512 MiB DRAM + select TQMa6S variant with i.MX6S + with 512 MiB DRAM endchoice @@ -46,12 +49,14 @@ choice config TQMA6X_MMC_BOOT bool "MMC / SD Boot" help - Boot from eMMC / SD Card + Boot from + eMMC / SD Card config TQMA6X_SPI_BOOT bool "SPI NOR Boot" help - Boot from on board SPI NOR flash + Boot from + board SPI NOR flash endchoice @@ -59,7 +64,8 @@ choice prompt "TQMa6 base board variant" default MBA6 help - Select base board for TQMa6 + Select the baseboard variant for the TQMa6 module. + By default the MBA6 starterkit is used. config MBA6 bool "TQMa6 on MBa6 Starterkit" @@ -80,7 +86,8 @@ config MBA6 config WRU4 bool "OHB WRU-IV" help - Select the OHB Systems AG WRU-IV baseboard. + Select the + OHB Systems AG WRU-IV baseboard. endchoice diff --git a/board/tq/tqma6/tqma6.c b/board/tq/tqma6/tqma6.c index a7317b9e761..83db2d1ad38 100644 --- a/board/tq/tqma6/tqma6.c +++ b/board/tq/tqma6/tqma6.c @@ -37,7 +37,6 @@ int dram_init(void) static const uint16_t tqma6_emmc_dsr = 0x0100; - int board_early_init_f(void) { return tqma6_bb_board_early_init_f(); @@ -60,16 +59,12 @@ static const char *tqma6_get_boardname(void) switch ((cpurev & 0xFF000) >> 12) { case MXC_CPU_MX6SOLO: return "TQMa6S"; - break; case MXC_CPU_MX6DL: return "TQMa6DL"; - break; case MXC_CPU_MX6D: return "TQMa6D"; - break; case MXC_CPU_MX6Q: return "TQMa6Q"; - break; default: return "??"; }; diff --git a/board/tq/tqma6/tqma6_mba6.c b/board/tq/tqma6/tqma6_mba6.c index b8f76591006..630ffdd63a9 100644 --- a/board/tq/tqma6/tqma6_mba6.c +++ b/board/tq/tqma6/tqma6_mba6.c @@ -74,7 +74,7 @@ int board_mmc_get_env_dev(int devno) * the boot device first ... * Note: SDHC3 == idx2 */ - return (2 == devno) ? 0 : 1; + return (devno == 2) ? 0 : 1; } int board_phy_config(struct phy_device *phydev) -- 2.47.3