From 87a95504bb01a8662c08bd0a7367c5cc92286aa3 Mon Sep 17 00:00:00 2001 From: Kamil Dudka Date: Wed, 30 Aug 2017 13:50:42 +0200 Subject: [PATCH] expr: fix a recently introduced memory leak * src/expr.c (eval6): Free memory allocated by mbs_logical_substr(). Introduced in v8.27-47-ga9f2be5. Detected by Coverity Analysis: Error: RESOURCE_LEAK: src/expr.c:851: leaked_storage: Variable "s" going out of scope leaks the storage it points to. 849| char *s = mbs_logical_substr (l->u.s, pos, len); 850| v = str_value (s); 851|-> } 852| freev (l); 853| freev (i1); --- src/expr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/expr.c b/src/expr.c index 795140ce98..194b54b537 100644 --- a/src/expr.c +++ b/src/expr.c @@ -848,6 +848,7 @@ eval6 (bool evaluate) char *s = mbs_logical_substr (l->u.s, pos, len); v = str_value (s); + free (s); } freev (l); freev (i1); -- 2.47.2