From 87ee3f05bfe2f5955c2c77ae26a1be236fd615a5 Mon Sep 17 00:00:00 2001 From: Chen Ni Date: Mon, 26 Jan 2026 15:35:28 +0800 Subject: [PATCH] ASoC: codecs: wm8731: Remove unnecessary NULL check before clk_prepare_enable/clk_disable_unprepare clk_prepare_enable() and clk_disable_unprepare() already checked NULL clock parameter. Remove unneeded NULL check for wm8731->mclk here. Signed-off-by: Chen Ni Reviewed-by: Charles Keepax Link: https://patch.msgid.link/20260126073528.1826406-1-nichen@iscas.ac.cn Signed-off-by: Mark Brown --- sound/soc/codecs/wm8731.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/wm8731.c b/sound/soc/codecs/wm8731.c index a03bbde5d8527..a2f0e2f5c4070 100644 --- a/sound/soc/codecs/wm8731.c +++ b/sound/soc/codecs/wm8731.c @@ -471,11 +471,9 @@ static int wm8731_set_bias_level(struct snd_soc_component *component, switch (level) { case SND_SOC_BIAS_ON: - if (wm8731->mclk) { - ret = clk_prepare_enable(wm8731->mclk); - if (ret) - return ret; - } + ret = clk_prepare_enable(wm8731->mclk); + if (ret) + return ret; break; case SND_SOC_BIAS_PREPARE: break; @@ -494,8 +492,7 @@ static int wm8731_set_bias_level(struct snd_soc_component *component, snd_soc_component_write(component, WM8731_PWR, reg | 0x0040); break; case SND_SOC_BIAS_OFF: - if (wm8731->mclk) - clk_disable_unprepare(wm8731->mclk); + clk_disable_unprepare(wm8731->mclk); snd_soc_component_write(component, WM8731_PWR, 0xffff); regulator_bulk_disable(ARRAY_SIZE(wm8731->supplies), wm8731->supplies); -- 2.47.3