From 89a8862d4277e26661e5eed86ea75afc0e8c38ce Mon Sep 17 00:00:00 2001 From: Andrea Bolognani Date: Mon, 22 Jan 2024 18:50:17 +0100 Subject: [PATCH] qemu: Add missing error handling qemuDomainGetSCSIControllerModel() can return -1 on failure, but qemuDomainFindOrCreateSCSIDiskController() didn't implement any handling for this scenario. Signed-off-by: Andrea Bolognani Reviewed-by: Peter Krempa --- src/qemu/qemu_hotplug.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 31b00e05ca..137904034d 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -881,6 +881,11 @@ qemuDomainFindOrCreateSCSIDiskController(virDomainObj *vm, else cont->model = model; + if (cont->model < 0) { + VIR_FREE(cont); + return NULL; + } + VIR_INFO("No SCSI controller present, hotplugging one model=%s", virDomainControllerModelSCSITypeToString(cont->model)); if (qemuDomainAttachControllerDevice(vm, cont) < 0) { -- 2.47.2