From 8a0fbde88ea3798377905f3685990ac565e86be3 Mon Sep 17 00:00:00 2001 From: Kamalesh Babulal Date: Fri, 30 Sep 2022 08:38:06 -0600 Subject: [PATCH] tools/cgdelete: use exit code 129 on invalid usage The exit code 1 refers to general error and using -1 wraps to 255, both codes do not signify bad arguments. Let's use exit code 129 (EXIT_BADARGS) for hinting to the users about invalid usage. Signed-off-by: Kamalesh Babulal Signed-off-by: Tom Hromatka (cherry picked from commit 1020f6279444f016f8e12816f827d14cd5a8d525) --- src/tools/cgdelete.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/tools/cgdelete.c b/src/tools/cgdelete.c index 28ddca35..8bedc5de 100644 --- a/src/tools/cgdelete.c +++ b/src/tools/cgdelete.c @@ -125,7 +125,7 @@ int main(int argc, char *argv[]) if (argc < 2) { usage(1, argv[0]); - exit (1); + exit(EXIT_BADARGS); } /* initialize libcg */ @@ -160,7 +160,7 @@ int main(int argc, char *argv[]) ret = parse_cgroup_spec(cgroup_list, optarg, argc); if (ret != 0) { err("%s: error parsing cgroup '%s'", argv[0], optarg); - ret = -1; + ret = EXIT_BADARGS; goto err; } break; @@ -170,7 +170,7 @@ int main(int argc, char *argv[]) goto err; default: usage(1, argv[0]); - ret = -1; + ret = EXIT_BADARGS; goto err; } } @@ -180,7 +180,7 @@ int main(int argc, char *argv[]) ret = parse_cgroup_spec(cgroup_list, argv[i], argc); if (ret != 0) { err("%s: error parsing cgroup '%s'\n", argv[0], argv[i]); - ret = -1; + ret = EXIT_BADARGS; goto err; } } -- 2.47.2