From 8a1de0ec9709b58a80a86a20cfba107b11c85f6e Mon Sep 17 00:00:00 2001 From: Phil Sutter Date: Wed, 16 Jul 2025 14:26:08 +0200 Subject: [PATCH] mnl: Call mnl_attr_nest_end() just once Calling the function after each added nested attribute is harmless but pointless. Fixes: a66b5ad9540dd ("src: allow for updating devices on existing netdev chain") Signed-off-by: Phil Sutter --- src/mnl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mnl.c b/src/mnl.c index 89bc742a..43229f24 100644 --- a/src/mnl.c +++ b/src/mnl.c @@ -811,8 +811,8 @@ static void mnl_nft_chain_devs_build(struct nlmsghdr *nlh, struct cmd *cmd) for (i = 0; i < num_devs; i++) { cmd_add_loc(cmd, nlh, dev_array[i].location); mnl_attr_put_strz(nlh, NFTA_DEVICE_NAME, dev_array[i].ifname); - mnl_attr_nest_end(nlh, nest_dev); } + mnl_attr_nest_end(nlh, nest_dev); } nft_dev_array_free(dev_array); } -- 2.47.2