From 8aa00035faeb307c061dc20e62a0ace7f2a1413b Mon Sep 17 00:00:00 2001 From: Amitay Isaacs Date: Fri, 5 Aug 2016 13:10:28 +1000 Subject: [PATCH] ctdb-client: transaction_cancel must free transaction handle BUG: https://bugzilla.samba.org/show_bug.cgi?id=12122 Signed-off-by: Amitay Isaacs Reviewed-by: Martin Schwenke --- ctdb/client/client_db.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ctdb/client/client_db.c b/ctdb/client/client_db.c index 98de1b858b3..794119d2f0d 100644 --- a/ctdb/client/client_db.c +++ b/ctdb/client/client_db.c @@ -2304,6 +2304,7 @@ static void ctdb_transaction_cancel_done(struct tevent_req *subreq) DEBUG(DEBUG_ERR, ("transaction_cancel: %s g_lock unlock failed, ret=%d\n", state->h->db->db_name, ret)); + talloc_free(state->h); tevent_req_error(req, ret); return; } @@ -2336,6 +2337,7 @@ int ctdb_transaction_cancel(struct ctdb_transaction_handle *h) mem_ctx = talloc_new(NULL); if (mem_ctx == NULL) { + talloc_free(h); return ENOMEM; } @@ -2343,6 +2345,7 @@ int ctdb_transaction_cancel(struct ctdb_transaction_handle *h) tevent_timeval_zero(), h); if (req == NULL) { talloc_free(mem_ctx); + talloc_free(h); return ENOMEM; } -- 2.47.2