From 8c19f86e356cd28180eb199f07670de5f32f82b9 Mon Sep 17 00:00:00 2001 From: "Jose E. Marchesi" Date: Sat, 17 May 2014 11:20:27 -0700 Subject: [PATCH] Fix sparc memcpy data corruption when using niagara2 optimized routines. * sysdeps/sparc/sparc64/multiarch/memcpy-niagara2.S: Add missing membar to avoid block loads/stores to overlap previous stores. --- ChangeLog | 6 ++++++ NEWS | 2 +- sysdeps/sparc/sparc64/multiarch/memcpy-niagara2.S | 1 + 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 7e235ac392c..ef667cc9b9a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2014-05-17 Jose E. Marchesi + + [BZ #16958] + * sysdeps/sparc/sparc64/multiarch/memcpy-niagara2.S: Add missing + membar to avoid block loads/stores to overlap previous stores. + 2014-05-16 Aurelien Jarno [BZ #16943] diff --git a/NEWS b/NEWS index 7703b6ee1c2..9ab955a3015 100644 --- a/NEWS +++ b/NEWS @@ -8,7 +8,7 @@ using `glibc' in the "product" field. Version 2.17.1 * The following bugs are resolved with this release: - 15003, 15006, 15073, 15122, 15759, 16510, 16885, 16916, 16943. + 15003, 15006, 15073, 15122, 15759, 16510, 16885, 16916, 16943, 16958. Version 2.17 diff --git a/sysdeps/sparc/sparc64/multiarch/memcpy-niagara2.S b/sysdeps/sparc/sparc64/multiarch/memcpy-niagara2.S index fb815e5e571..93f87f73906 100644 --- a/sysdeps/sparc/sparc64/multiarch/memcpy-niagara2.S +++ b/sysdeps/sparc/sparc64/multiarch/memcpy-niagara2.S @@ -211,6 +211,7 @@ ENTRY(__memcpy_niagara2) */ VISEntryHalf + membar #Sync alignaddr %o1, %g0, %g0 add %o1, (64 - 1), %o4 -- 2.47.2