From 8d2a3cd69a260f324587d40566a8e6f907e02dde Mon Sep 17 00:00:00 2001 From: Kamalesh Babulal Date: Fri, 30 Sep 2022 08:40:28 -0600 Subject: [PATCH] tools/cgconfig: use exit code 129 on invalid usage The exit code 1 refers to general error and using -1 wraps to 255, both codes do not signify bad arguments. Let's use exit code 129 (EXIT_BADARGS) for hinting to the users about invalid usage. Signed-off-by: Kamalesh Babulal Signed-off-by: Tom Hromatka (cherry picked from commit 946f92b6042faa539d2a146eb4c42aa61e061b1f) --- src/tools/cgconfig.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/tools/cgconfig.c b/src/tools/cgconfig.c index ef57e184..b541d4b1 100644 --- a/src/tools/cgconfig.c +++ b/src/tools/cgconfig.c @@ -80,7 +80,7 @@ int main(int argc, char *argv[]) cgroup_set_default_logger(-1); if (argc < 2) { usage(1, argv[0]); - return -1; + exit(EXIT_BADARGS); } ret = cgroup_init(); @@ -141,14 +141,14 @@ int main(int argc, char *argv[]) break; default: usage(1, argv[0]); - error = -1; + error = EXIT_BADARGS; goto err; } } if (argv[optind]) { usage(1, argv[0]); - error = -1; + error = EXIT_BADARGS; goto err; } -- 2.47.2