From 8ecd67e18e0890abf3fff33fa427082691fa43a4 Mon Sep 17 00:00:00 2001 From: Luca Boccassi Date: Sun, 16 Jul 2023 00:39:13 +0100 Subject: [PATCH] efi: add assert to silence coverity CID#1502668 --- src/boot/efi/efi-string.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/boot/efi/efi-string.c b/src/boot/efi/efi-string.c index 44005912559..ffe85524530 100644 --- a/src/boot/efi/efi-string.c +++ b/src/boot/efi/efi-string.c @@ -544,9 +544,11 @@ static bool push_str(FormatContext *ctx, SpecifierContext *sp) { if (sp->wstr && sizeof(wchar_t) == sizeof(char16_t)) { memcpy(ctx->buf + ctx->n, sp->wstr, sp->len * sizeof(*sp->wstr)); ctx->n += sp->len; - } else + } else { + assert(sp->str || sp->wstr); for (size_t i = 0; i < sp->len; i++) ctx->buf[ctx->n++] = sp->str ? sp->str[i] : sp->wstr[i]; + } if (sp->align_left) push_padding(ctx, ' ', sp->padded_len); -- 2.47.3