From 8f10fa069b52338eadba593761706d49bcd5b5b8 Mon Sep 17 00:00:00 2001 From: Christophe Jaillet Date: Fri, 9 Aug 2019 06:49:46 +0000 Subject: [PATCH] Fix a corner case where automatic APLOGNO number generation generates invalid code. (see r1864733 fixed in r1864736, thx Eric) Not sure why this ,? is there, but it looks uneeded to me. There is maybe a link with the patterns used in 'find-messages.cocci'. They seem to add some extra , after the empty APLOGNO() it generates. I will investigate further and fix 'find-messages.cocci' accordingly if needed. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1864771 13f79535-47bb-0310-9956-ffa450edef68 --- docs/log-message-tags/update-log-msg-tags | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/log-message-tags/update-log-msg-tags b/docs/log-message-tags/update-log-msg-tags index a034fd49ce2..21b740bf86b 100755 --- a/docs/log-message-tags/update-log-msg-tags +++ b/docs/log-message-tags/update-log-msg-tags @@ -37,7 +37,7 @@ sub process my $modified; my $result = ""; while (defined $line) { - if ($line =~ s{APLOGNO\(\),?}{gen_tag($file)}e) { + if ($line =~ s{APLOGNO\(\)}{gen_tag($file)}e) { $modified = 1; } if ($line =~ /APLOGNO\(\s*(\d{5})\s*\)/ ) { -- 2.47.3