From 8f7e897995ae49546ab94a6969e85d797ac6c486 Mon Sep 17 00:00:00 2001 From: "Dr. David von Oheimb" Date: Fri, 26 Jun 2020 12:37:12 +0200 Subject: [PATCH] apps/cmp.c: Defer diagnostic output on server+proxy to be contacted Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/12296) --- apps/cmp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/apps/cmp.c b/apps/cmp.c index e5f72cbea78..1af53510b32 100644 --- a/apps/cmp.c +++ b/apps/cmp.c @@ -2095,7 +2095,6 @@ static int setup_client_ctx(OSSL_CMP_CTX *ctx, ENGINE *engine) if (opt_proxy != NULL) (void)BIO_snprintf(proxy_buf, sizeof(proxy_buf), " via %s", opt_proxy); - CMP_info2("will contact %s%s", server_buf, proxy_buf); if (!transform_opts()) goto err; @@ -2217,6 +2216,9 @@ static int setup_client_ctx(OSSL_CMP_CTX *ctx, ENGINE *engine) if (opt_geninfo != NULL && !handle_opt_geninfo(ctx)) goto err; + /* not printing earlier, to minimize confusion in case setup fails before */ + CMP_info2("will contact %s%s", server_buf, proxy_buf); + ret = 1; err: -- 2.47.2