From 903673eecb84bcecda2551e2cdd6710ce596abed Mon Sep 17 00:00:00 2001 From: =?utf8?q?Nikola=20Forr=C3=B3?= Date: Thu, 16 Jan 2020 18:43:51 +0100 Subject: [PATCH] api.c: Preserve dirty flag when copying controller values MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit When setting cgroup parameters with cgset fails, no error is reported. This is caused by the fact that cgroup_copy_controller_values is not preserving dirty flags of the values, so it's making all errors considered non-fatal. Signed-off-by: Nikola Forró Reviewed-by: Tom Hromatka --- src/api.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/api.c b/src/api.c index 959a8140..e7a07cfc 100644 --- a/src/api.c +++ b/src/api.c @@ -1751,6 +1751,7 @@ static int cgroup_copy_controller_values(struct cgroup_controller *dst, dst_val = dst->values[i]; strncpy(dst_val->value, src_val->value, CG_VALUE_MAX); strncpy(dst_val->name, src_val->name, FILENAME_MAX); + dst_val->dirty = src_val->dirty; } err: return ret; -- 2.47.2