From 9076d90684c06c8f0ac0ba4c099b00ddbc4ab29d Mon Sep 17 00:00:00 2001 From: Selva Nair Date: Fri, 21 Jan 2022 13:57:52 -0500 Subject: [PATCH] Do not error when md_kt_size() is called with mdname="none" An easy way to trigger this error is to run an otherwise working setup (at say verb = 4) with increased verbosity of verb >= 7 and using a GCM cipher (e.g., AES-256-GCM). It will cause a fatal exit while printing the cipher and hmac in key2_print(). Signed-off-by: Selva Nair Acked-by: Gert Doering Message-Id: <20220121185752.14138-1-selva.nair@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg23631.html Signed-off-by: Gert Doering --- src/openvpn/crypto_openssl.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/openvpn/crypto_openssl.c b/src/openvpn/crypto_openssl.c index 5f8c575ec..a725306cc 100644 --- a/src/openvpn/crypto_openssl.c +++ b/src/openvpn/crypto_openssl.c @@ -1073,6 +1073,10 @@ md_kt_name(const char *mdname) unsigned char md_kt_size(const char *mdname) { + if (!strcmp("none", mdname)) + { + return 0; + } evp_md_type *kt = md_get(mdname); unsigned char size = (unsigned char)EVP_MD_size(kt); EVP_MD_free(kt); -- 2.47.2