From 9181b66c253df3ef00fbc99763a5242a9fdf86bc Mon Sep 17 00:00:00 2001 From: liuli Date: Fri, 3 Sep 2021 10:23:18 +0800 Subject: [PATCH] fix _cupsGet1284Values MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit when 1284id doesn't end with semicolon,_cupsGet1284Values() cannot get last key and value. eg. uos@uos-PC:/usr/lib/cups/backend/snmp 10.10.120.220 network socket://10.10.120.220 "Unknown" "FUJI XEROX ApeosPort-V 4070 v 3. 43. 0 Multifunction System" "MANUFACTURER:FUJI XEROX;MODEL:ApeosPort-V 4070" "" --- cups/options.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/cups/options.c b/cups/options.c index 11814c9af2..b95785b84d 100644 --- a/cups/options.c +++ b/cups/options.c @@ -598,12 +598,13 @@ _cupsGet1284Values( if (!*device_id) break; - + + memset(value, 0, sizeof(value)); for (ptr = value; *device_id && *device_id != ';'; device_id ++) if (ptr < (value + sizeof(value) - 1)) *ptr++ = *device_id; - if (!*device_id) + if (!*device_id && strlen(value) == 0) break; while (ptr > value && _cups_isspace(ptr[-1])) -- 2.47.2